Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33066: Fix table style

Browse source 
Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width
Remove unecessary table styling

JD: following commit has been squashed. Patch from Pedro is fixing the
FIXME
"""
Bug 33066: Fix style - FIXME

This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1
The table is not taking width: 100%
I fixed it previously with the display: table in the style block, but
here it's not applied.

There is also the "green tick" (fa-check-square-o) that is not on the
same line https://snipboard.io/jma923.jpg
"""

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Pedro Amorim 2023-03-26 10:53:25 +00:00 committed by Tomas Cohen Arazi
parent 0a89bf85e0
commit 8a63e6eecc
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
5 changed files with 10 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
View file

@ -326,9 +326,6 @@ export default {
</script>
<style scoped>
#agreement_list {
display: table;
}
.filters > label[for="by_mine_filter"],
.filters > input[type="checkbox"],
.filters > input[type="button"] {

3
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue
View file

@ -199,9 +199,6 @@ export default {
</script>
<style scoped>
#title_list {
display: table;
}
#filters {
margin: 0;
}

12
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue
View file

@ -90,15 +90,13 @@
<label
>Titles ({{ erm_package.resources_count }})</label
>
<div v-if="erm_package.resources_count">
<EHoldingsPackageTitlesList
:package_id="erm_package.package_id.toString()"
/>
</div>
</li>
<li></li>
</ol>
<div v-if="erm_package.resources_count">
<EHoldingsPackageTitlesList
:package_id="erm_package.package_id.toString()"
/>
</div>
</fieldset>
<fieldset class="action">
<router-link

6
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue
View file

@ -93,9 +93,3 @@ export default {
name: "EHoldingsLocalPackageTitlesList",
}
</script>
<style scoped>
#title_list {
display: table;
}
</style>

12
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue
View file

@ -82,15 +82,13 @@
erm_package.resources_count
)
}}</label>
<div v-if="erm_package.resources_count">
<EHoldingsPackageTitlesList
:package_id="erm_package.package_id.toString()"
/>
</div>
</li>
<li></li>
</ol>
<div v-if="erm_package.resources_count">
<EHoldingsPackageTitlesList
:package_id="erm_package.package_id.toString()"
/>
</div>
</fieldset>
<fieldset class="action">
<router-link