Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items

If you are non logged-in and you the search result contain lost items,
you will get:
Can't call method "category" on an undefined value at
/home/liz/koha-src/koha/C4/Search.pm line 2091.

This is because bug 17556 assumed that $userenv was not defined when the
user is logged out. Actually it is, with non defined or empty string
values.

Test plan:
Do a search in the opac that would turn up a whole list of results (and
not just that one) with the lost item included.
 => Without this patch you should get an error
 => With this patch applied you should see the search results

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-12-13 12:28:35 +00:00 committed by Brendan A Gallagher
parent c86a9e4d30
commit 8db17f9eca

View file

@ -2090,6 +2090,7 @@ sub searchResults {
my $userenv = C4::Context->userenv;
if ( $item->{onloan}
&& $userenv
&& $userenv->{number}
&& !( Koha::Patrons->find($userenv->{number})->category->hidelostitems && $item->{itemlost} ) )
{
$onloan_count++;