From 8e739ab00c092565ce6fe1e3f17b46834717ade2 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 10 Oct 2022 17:09:27 +0000
Subject: [PATCH] Bug 31730: Link to authorized value interface when an authval
 is mentioned in preferences

This patch adds links to the authorized value interface anywhere an
authorized value category is mentioned in a system preference
description.

To test, apply the patch and go to Administration -> System preferences.

- Check these preferences:
  Circulation -> ILLHiddenRequestStatuses
  Circulation -> BundleLostValue
  Circulation -> BundleNotLoanValue
  Circulation -> ClaimReturnedLostValue
  Accounting -> RequirePaymentType
- Confirm that the link in the description of each preference takes you
  to the correct authorized value category.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/admin/preferences/accounting.pref     | 2 +-
 .../prog/en/modules/admin/preferences/circulation.pref    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
index cb79d1d379..e857a77c3a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
@@ -18,7 +18,7 @@ Accounting:
                   0: "Don't require"
                   1: "Require"
             - staff to select a payment type when a payment is made.
-            - This preference has no effect when <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseCashRegisters">UseCashRegisters</a> is enabled or when no payment types are defined in the PAYMENT_TYPE authorised value category.
+            - This preference has no effect when <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseCashRegisters">UseCashRegisters</a> is enabled or when no payment types are defined in the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=PAYMENT_TYPE">PAYMENT_TYPE authorized value category</a>.
         -
             - pref: RoundFinesAtPayment
               choices:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
index 4eb7ba73fe..b4dcd53c01 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -1036,7 +1036,7 @@ Circulation:
             - "ILL statuses that are considered finished and should not be displayed in the ILL module: "
             - pref: ILLHiddenRequestStatuses
               class: multi
-            - (separated with |). If left empty, all ILL requests will be displayed. The request codes can be found in the ILLSTATUS authorized value category.
+            - (separated with |). If left empty, all ILL requests will be displayed. The request codes can be found in the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=ILLSTATUS">ILLSTATUS authorized value category</a>.
         -
             - "Send these ILL notices to staff when appropriate:"
             - pref: ILLSendStaffNotices
@@ -1327,11 +1327,11 @@ Circulation:
 
     Item bundles:
         -
-            - Use the LOST authorised value
+            - Use the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST authorized value</a>
             - pref: BundleLostValue
             - to represent 'missing from bundle' at return.
         -
-            - Use the NOT_LOAN authorised value
+            - Use the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">NOT_LOAN authorized value</a>
             - pref: BundleNotLoanValue
             - to represent 'added to bundle' when an item is attached to bundle.
 
@@ -1346,7 +1346,7 @@ Circulation:
                   no_charge: don't charge a lost fee
             - .
         -
-            - Use the LOST authorised value
+            - Use the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST authorized value</a>
             - pref: ClaimReturnedLostValue
             - to represent 'claims returned'.
         -