Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34478: (follow-up) patroncards: FIXMEs for op and missing script

Browse source 
Looks like create-csv never made it.
Some op's look like GET to me. Creating a pdf is just downloading.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2024-02-23 10:23:41 +00:00 committed by Jonathan Druart
parent 195cccd4ef
commit 8eed84fe0b
Signed by: jonathan.druart
GPG key ID: A085E712BEF0E0F0
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
patroncards/edit-profile.pl
View file

@ -45,7 +45,7 @@ my @label_template = ();
my $units = get_unit_values();
if ($op eq 'cud-edit') {
if ($op eq 'cud-edit') { # FIXME This looks like edit_form ?
$profile = C4::Patroncards::Profile->retrieve(profile_id => $profile_id);
$template_list = get_all_templates({ fields => [ qw( template_id template_code profile_id ) ] });
}

2
patroncards/edit-template.pl
View file

@ -45,7 +45,7 @@ my $profile_list = undef;
my $units = get_unit_values();
if ($op eq 'cud-edit') {
if ($op eq 'cud-edit') { # FIXME This looks like edit_form
$card_template = C4::Patroncards::Template->retrieve(template_id => $template_id);
$profile_list = get_all_profiles({ fields => [ qw( profile_id printer_name paper_bin ) ], filters => {template_id => [ $template_id, 0 ], creator => 'Patroncards'} } );
}

8
patroncards/print.pl
View file

@ -56,11 +56,11 @@ my $multi_batch_count = scalar(@batch_ids);
my $card_count = scalar(@label_ids);
my $borrower_count = scalar(@borrower_numbers);
if ($op eq 'cud-export') {
if ($op eq 'cud-export') { #FIXME Seems like a GET operation?
if (@label_ids) {
my $label_id_param = '&amp;label_id=';
$label_id_param .= join ('&amp;label_id=',@label_ids);
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'),
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'), #FIXME csv not supported, no script?
batch_id => $batch_ids[0],
template_id => $template_id,
layout_id => $layout_id,
@ -77,7 +77,7 @@ if ($op eq 'cud-export') {
elsif (@borrower_numbers) {
my $borrower_number_param = '&amp;borrower_number=';
$borrower_number_param .= join ('&amp;borrower_number=',@borrower_numbers);
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'),
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'), #FIXME csv not supported, no script?
template_id => $template_id,
layout_id => $layout_id,
layout_back_id => $layout_back_id,
@ -92,7 +92,7 @@ if ($op eq 'cud-export') {
}
elsif (@batch_ids) {
foreach my $batch_id (@batch_ids) {
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'),
push (@batches, {create_script => ($output_format eq 'pdf' ? 'create-pdf.pl' : 'create-csv.pl'), #FIXME csv not supported, no script?
batch_id => $batch_id,
template_id => $template_id,
layout_id => $layout_id,