Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28234: TestBuilder->build_sample_biblio should set UTF-8 encoding for record

Browse source 
This patch makes the build_sample_biblio method, correctly set the UTF-8
flag for the MARC::Record object.

Tests are added.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/TestBuilder.t
FAIL: Tests fail! An unexpected encoding warning shows
3. Apply this patch
4. Repeat 2
=> SUCCESS: No warning! Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomás Cohen Arazi 2021-04-27 08:24:57 -03:00 committed by Jonathan Druart
parent e5f43c6868
commit 8fce3401e7
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
t/lib/TestBuilder.pm
View file

@ -155,6 +155,8 @@ sub build_sample_biblio {
my $marcflavour = C4::Context->preference('marcflavour');
my $record = MARC::Record->new();
$record->encoding( 'UTF-8' );
my ( $tag, $subfield ) = $marcflavour eq 'UNIMARC' ? ( 200, 'a' ) : ( 245, 'a' );
$record->append_fields(
MARC::Field->new( $tag, ' ', ' ', $subfield => $title ),