Bug 33164: Do not prevent processing of all error messages
This follow-up patch removes the use of $exit_required_p completely. The sysprefs BlockReturnOfLostItems and BlockReturnOfWithdrawnItems are handled in other scripts, and should not prevent the processing of all returns error messages when enabled. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit64460e4f4e
) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commit53370581fd
) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
This commit is contained in:
parent
f9ba89ade4
commit
8febe5ed4e
1 changed files with 0 additions and 3 deletions
|
@ -649,7 +649,6 @@ if ( $messages->{TransferredRecall} ) {
|
|||
my @errmsgloop;
|
||||
foreach my $code ( keys %$messages ) {
|
||||
my %err;
|
||||
my $exit_required_p = 0;
|
||||
if ( $code eq 'BadBarcode' ) {
|
||||
$err{badbarcode} = 1;
|
||||
$err{msg} = $messages->{'BadBarcode'};
|
||||
|
@ -687,7 +686,6 @@ foreach my $code ( keys %$messages ) {
|
|||
}
|
||||
elsif ( $code eq 'withdrawn' ) {
|
||||
$err{withdrawn} = 1;
|
||||
$exit_required_p = 1 if C4::Context->preference("BlockReturnOfWithdrawnItems");
|
||||
}
|
||||
elsif ( $code eq 'WrongTransfer' ) {
|
||||
; # FIXME... anything to do here?
|
||||
|
@ -743,7 +741,6 @@ foreach my $code ( keys %$messages ) {
|
|||
if (%err) {
|
||||
push( @errmsgloop, \%err );
|
||||
}
|
||||
last if $exit_required_p;
|
||||
}
|
||||
$template->param( errmsgloop => \@errmsgloop );
|
||||
|
||||
|
|
Loading…
Reference in a new issue