Bug 26518: Move BiblioAutoLink within the transaction

We don't want the authorities to be created if the biblio insert fails
later

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2020-10-12 15:01:22 +02:00
parent 1519050205
commit 9038cdd9a4

View file

@ -206,20 +206,19 @@ sub AddBiblio {
$defer_marc_save = 1;
}
if (C4::Context->preference('BiblioAddsAuthorities')) {
BiblioAutoLink( $record, $frameworkcode );
}
my ( $biblionumber, $biblioitemnumber, $error );
my $dbh = C4::Context->dbh;
# transform the data into koha-table style data
SetUTF8Flag($record);
my $olddata = TransformMarcToKoha( $record, $frameworkcode );
my $schema = Koha::Database->schema;
my ( $biblionumber, $biblioitemnumber );
try {
$schema->txn_do(sub {
if (C4::Context->preference('BiblioAddsAuthorities')) {
BiblioAutoLink( $record, $frameworkcode );
}
# transform the data into koha-table style data
SetUTF8Flag($record);
my $olddata = TransformMarcToKoha( $record, $frameworkcode );
my $biblio = Koha::Biblio->new(
{
frameworkcode => $frameworkcode,