Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28936: Add sort1/sort2 to borrowers.json

Browse source 
To Test:
1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required
2. Apply patch
3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2
4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields
5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences
6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField
7. sort1 and sort2 should be disabled in these OPAC system preferences

This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Lucas Gass 2021-09-01 16:24:52 +00:00 committed by Jonathan Druart
parent f11453e6cc
commit 90d6d1b4a7
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
View file

@ -52,5 +52,7 @@
"altcontactcountry": "altcontactcountry", "altcontactcountry": "altcontactcountry",
"altcontactphone": "altcontactphone", "altcontactphone": "altcontactphone",
"smsalertnumber": "smsalertnumber", "smsalertnumber": "smsalertnumber",
"primary_contact_method": "primary_contact_method" "primary_contact_method": "primary_contact_method",
"sort1": "sort1",
"sort2": "sort2"
} }

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
View file

@ -828,17 +828,19 @@ OPAC:
- pref: PatronSelfRegistrationBorrowerMandatoryField - pref: PatronSelfRegistrationBorrowerMandatoryField
type: modalselect type: modalselect
source: borrowers source: borrowers
exclusions: sort1|sort2
- -
- "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-registration screen:" - "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-registration screen:"
- pref: PatronSelfRegistrationBorrowerUnwantedField - pref: PatronSelfRegistrationBorrowerUnwantedField
type: modalselect type: modalselect
source: borrowers source: borrowers
exclusions: branchcode exclusions: branchcode|sort1|sort2
- -
- "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-modification screen:" - "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-modification screen:"
- pref: PatronSelfModificationBorrowerUnwantedField - pref: PatronSelfModificationBorrowerUnwantedField
type: modalselect type: modalselect
source: borrowers source: borrowers
exclusions: sort1|sort2
- -
- "Display the following additional instructions for patrons who self register via the OPAC ( HTML is allowed ):" - "Display the following additional instructions for patrons who self register via the OPAC ( HTML is allowed ):"
- pref: PatronSelfRegistrationAdditionalInstructions - pref: PatronSelfRegistrationAdditionalInstructions