Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 5583 Rename fieldnumber to blocknumber

Browse source 
Variable fieldnumber does not refer to a field
It is the ISBD block number
Rename to blocknumber
Say what we mean adds to maintainability

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Colin Campbell 2011-01-06 11:37:19 +00:00 committed by Chris Cormack
parent 782654d178
commit 926ab8c544
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
View file

@ -67,11 +67,11 @@ function PopupZ3950() {
}
}
function PopupMARCFieldDoc(field, fieldnumber) {
function PopupMARCFieldDoc(field, blocknumber) {
<!-- TMPL_IF NAME="MARC21" -->
_MARC21FieldDoc(field);
<!-- TMPL_ELSE -->
_UNIMARCFieldDoc(field, fieldnumber);
_UNIMARCFieldDoc(field, blocknumber);
<!-- /TMPL_IF -->
}
@ -85,7 +85,7 @@ function _MARC21FieldDoc(field) {
}
}
function _UNIMARCFieldDoc(field,fieldnumber) {
function _UNIMARCFieldDoc(field, blocknumber) {
/* http://archive.ifla.org/VI/3/p1996-1/ is an outdated version of UNIMARC, but
seems to be the only version available that can be linked to per tag. More recent
versions of the UNIMARC standard are available on the IFLA website only as
@ -94,9 +94,9 @@ function _UNIMARCFieldDoc(field,fieldnumber) {
if(field == 0) {
window.open("http://archive.ifla.org/VI/3/p1996-1/uni.htm");
} else if (field < 100) {
window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+fieldnumber+".htm#b" + ("000"+field).slice(-3));
window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+blocknumber+".htm#b" + ("000"+field).slice(-3));
} else if (field < 900) {
window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+fieldnumber+".htm#" + ("000"+field).slice(-3));
window.open("http://archive.ifla.org/VI/3/p1996-1/uni"+blocknumber+".htm#" + ("000"+field).slice(-3));
} else {
window.open("http://archive.ifla.org/VI/3/p1996-1/uni9.htm");
}