Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13418: [QA Follow-up] Use unshift instead of push

Browse source 
Some SQL parameters are added to the wrong side of the list.
This effectively clears all private lists from view :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Marcel de Rooy 2015-01-19 15:05:03 +01:00 committed by Tomas Cohen Arazi
parent 273ead3084
commit 926e97b9e9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/VirtualShelves.pm
View file

@ -111,7 +111,7 @@ sub GetShelves {
LEFT JOIN virtualshelfshares sh ON sh.shelfnumber=vs.shelfnumber
AND sh.borrowernumber=?
WHERE category=1 AND (vs.owner=? OR sh.borrowernumber=?) };
push @params, ($owner) x 3;
unshift @params, ($owner) x 3;
}
else {
$query.= 'WHERE category=2 ';