Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36494: Flatpickr error on checkout page if the patron is blocked from checking out

Browse source 
This patch add some error-handling to the recent change to
circulation.tt where we handle dates and on-site checkouts. This
prevents an error in the console when the patron is blocked and the
"specify due date" field is hidden.

To test, apply the patch and make sure OnSiteCheckouts is enabled.

- Go to Circulation and check out to a patron.
- Under the restrictions tab, add a manual restriction.
- When the page reloads and the checkout form is no longer visible,
  confirm that there is no error in the browser console.

Confirm that the Bug 18885 test plan still works.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit cc15deb001)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Owen Leonard 2024-04-02 17:03:21 +00:00 committed by Fridolin Somers
parent 9dbc2737e1
commit 9334fe9392
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
View file

@ -1008,11 +1008,14 @@
// On-site checkout
function toggle_onsite_checkout(){
const duedatespec_fp = document.querySelector("#duedatespec")._flatpickr;
if ( $("#onsite_checkout").prop('checked') ) {
duedatespec_fp.setDate("[% today_due_date_and_time | $KohaDates dateformat => 'iso', with_hours => 1 %]");
} else {
duedatespec_fp.setDate("");
const duedatespec = document.querySelector("#duedatespec");
if( duedatespec ){
const duedatespec_fp = duedatespec._flatpickr;
if ( $("#onsite_checkout").prop('checked') ) {
duedatespec_fp.setDate("[% today_due_date_and_time | $KohaDates dateformat => 'iso', with_hours => 1 %]");
} else {
duedatespec_fp.setDate("");
}
}
}