Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)

Browse source 
In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template,
there is a surplus closing </div> in line 336 (= line 332, in case
Bug 12521 is applied first):

   336: </div> <!-- / .span4 -->

which causes some minor layout problems for this page - i.e.: page
footer ("Powered by Koha" + custom footer set up in system prefrences -
if any) is "glued" to the bottom (to the language selection bar);
unless Bug 12521 is applied first, this affects the placement of the
2nd search bar as well.

To reproduce:

1/ go to the OPAC advanced search page
2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the
result
3/ no need for step 2/ (zooming out) when using a display with
(relatively) high vertical resolution; also, this particullar problem
gets more apparent/more noticeable with MARC21/USMASRC "subtype"
options being hidden in the OPAC advanced search (Bug 9043).

To test:

1/ ensure that Bug 12521 is applied first/already applied
2/ apply patch
3/ confirm that this issue is no longer reroductible

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
On top of 12521, don't know exactly what to reproduce, but
surplus '</div>' is real (33 open, 34 close).
Everything looks correct, no koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jacek Ablewicz 2014-08-02 10:13:16 +02:00 committed by Tomas Cohen Arazi
parent 77e8cf024d
commit 9351cde90f
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
View file

@ -321,7 +321,8 @@
</fieldset>
</div> <!-- / .span3 -->
</div> <!-- / #subtypes -->
[% END # / IF usmarc %]
<!-- SUBTYPE LIMITS -->
[% END # / IF usmarc %]
[% IF ( UNIMARC ) %]
<div id="subtypes_unimarc">
@ -329,7 +330,7 @@
[% INCLUDE 'subtypes_unimarc.inc' %]
</div>
[% END %]
</div> <!-- / .span4 -->
</div> <!-- / .row-fluid -->
[% END # / IF expanded_options %]
</div> <!-- / .row-fluid -->