Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30524: Unit tests

Browse source 
Test plan:
Run t/Output.t
Run t/db_dependent/Auth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2023-06-23 11:52:28 +01:00 committed by Tomas Cohen Arazi
parent 0221fec5ac
commit 9497556fef
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 40 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
t/Output.t
View file

@ -17,16 +17,23 @@
use Modern::Perl;
use Test::More tests => 7;
use Test::More tests => 8;
use Test::Warn;
use Test::MockModule;
use File::Temp qw/tempfile/;
use CGI qw ( -utf8 );
use C4::Auth qw( get_template_and_user );
use t::lib::Mocks;
BEGIN {
use_ok('C4::Output', qw( output_html_with_http_headers parametrized_url ));
use_ok('C4::Output', qw( output_html_with_http_headers output_and_exit_if_error parametrized_url ));
}
our $output_module = Test::MockModule->new('C4::Output');
my $query = CGI->new();
my $cookie;
my $output = 'foobarbaz';
@ -93,3 +100,33 @@ subtest 'output_with_http_headers() tests' => sub {
like($stdout, qr/Access-control-allow-origin: https:\/\/koha-community\.org/, 'Header set to https://koha-community.org');
close STDOUT;
};
subtest 'output_and_exit_if_error() tests' => sub {
plan tests => 1;
$output_module->mock(
'output_and_exit',
sub {
my ( $query, $cookie, $template, $error ) = @_;
is( $error, 'wrong_csrf_token', 'Got right error message' );
}
);
t::lib::Mocks::mock_config( 'pluginsdir', [ C4::Context::temporary_directory ] );
my ( $fh, $fn ) = tempfile( SUFFIX => '.tt', UNLINK => 1, DIR => C4::Context::temporary_directory );
print $fh qq|[% blocking_error %]|;
close $fh;
my $query = CGI->new();
$query->param('csrf_token','');
my ( $template, $loggedinuser, $cookies ) = get_template_and_user(
{
template_name => $fn,
query => $query,
type => "intranet",
authnotrequired => 1,
}
);
# Next call triggers test in the mocked sub
output_and_exit_if_error($query, $cookie, $template, { check => 'csrf_token' });
};

1
t/db_dependent/Auth.t
View file

@ -602,6 +602,7 @@ subtest 'get_template_and_user' => sub { # Tests for the language URL paramete
);
is($template->{VARS}->{'opac_name'}, "multibranch-19", "Opac name was set correctly");
is($template->{VARS}->{'opac_search_limit'}, "branch:multibranch-19", "Search limit was set correctly");
ok(defined($template->{VARS}->{'csrf_token'}), "CSRF token returned");
delete $ENV{"HTTP_COOKIE"};
};