Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc

Browse source 
Two files av-build-dropbox.inc has linebreaks inside template directives,
 exposing internals (comments and tt code) to translations as mentioned
in initial comment.
Translators should not be confronted with such interal code.

This patch fixes it.

To test
- Verify, that code changes make sense and have no more line breaks insied
  tt directives.
- Run QA tools in newest version (checking for line breaks inside tt
  directives)
- Bonus test: Create a "language" aa-AA (perl translate create aa-AA
  from folder misc/translator, verify that lines mentioned above do
  no longer appear in aa-AA-staff-prog.po and in aa-AA-opac-bootstrap.po

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marc Véron 2017-05-30 14:27:56 +02:00 committed by Jonathan Druart
parent 1a023a670c
commit 953504a076
2 changed files with 15 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc
View file

@ -1,19 +1,14 @@
[% USE AuthorisedValues %]
[%#
Parameters:
name: the name of the select element
category: the authorised value category
default: the default authorised value to select
class: the CSS class of the select element
size: the size to use for the input (generated if the authorised value category does not exist).
all: add a "All" entry
%]
[%# Parameters: %]
[%# name: the name of the select element %]
[%# category: the authorised value category %]
[%# default: the default authorised value to select %]
[%# class: the CSS class of the select element %]
[%# size: the size to use for the input (generated if the authorised value category does not exist). %]
[%# all: add a "All" entry %]
[% SET avs = AuthorisedValues.GetAuthValueDropbox( category ) %]
[% DEFAULT
class = ''
size = 20
%]
[% DEFAULT class = '' size = 20 %]
[% IF avs %]
<select id="[% name %]" name="[% name %]" class="[% class %]" >

19
koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc
View file

@ -1,18 +1,13 @@
[% USE AuthorisedValues %]
[%#
Parameters:
name: the name of the select element
category: the authorised value category
default: the default authorised value to select
class: the CSS class of the select element
size: the size to use for the input (generated if the authorised value category does not exist).
%]
[%# Parameters: %]
[%# name: the name of the select element %]
[%# category: the authorised value category %]
[%# default: the default authorised value to select %]
[%# class: the CSS class of the select element %]
[%# size: the size to use for the input (generated if the authorised value category does not exist). %]
[% SET avs = AuthorisedValues.GetAuthValueDropbox( category ) %]
[% DEFAULT
class = ''
size = 20
%]
[% DEFAULT class = '' size = 20 %]
[% IF avs %]
<select id="[% name %]" name="[% name %]" class="[% class %]" >