Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords

Browse source 
It appears that an empty string is sneaking into the list of words
to highlight and that is causing the browser to freak out.

Test Plan:
1) Enable NoveList
2) Enable OpacHighlightedItems
3) Search a title with a series (i.e. The Hunger Games)
4) Click into the record
5) Click on the series to search it
6) Click on a title in the search results
7) If Firefox doesn't crash, it gives the unresponsive script message
8) Apply this patch
9) Repeat steps 3-6
10) Browser doesn't freak our

Signed-off-by: Jason Robb <jrobb@sekls.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
could not confirm the problem, but small change and
highlighting terms on result list and couldn't find any
regressions in highlighting.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Kyle Hall 2015-02-05 12:19:38 -05:00 committed by Tomas Cohen Arazi
parent 39c22b1a6a
commit 957e65c748
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View file

@ -1434,6 +1434,7 @@
[% IF ( query_desc ) %][% IF ( OpacHighlightedWords ) %]var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') |html %]"; [% IF ( query_desc ) %][% IF ( OpacHighlightedWords ) %]var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') |html %]";
q_array = query_desc.split(" "); q_array = query_desc.split(" ");
q_array = q_array.filter(function(n){ return n }); // Remove empty strings
highlightOn(); highlightOn();
$("#highlight_toggle_on" ).hide().click(function() {highlightOn() ; return false;}); $("#highlight_toggle_on" ).hide().click(function() {highlightOn() ; return false;});
$("#highlight_toggle_off").show().click(function() {highlightOff(); return false;});[% END %][% END %] $("#highlight_toggle_off").show().click(function() {highlightOff(); return false;});[% END %][% END %]