From 95ff9ad02d12cf89821c7d24aaf8e36f4a4593a2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 3 Sep 2024 11:03:17 +0200 Subject: [PATCH] Bug 35402: Fix regressions.t The audio alert feature is not correctly designed and is problematic. It looks at the class name in the DOM, not when the element with this class name will be displayed to the end user So it's not possible to make it work for modals for instance, or if an element is built in JS then displayed This patch remove the modal code from the code, if there are no waiting holds. It is the behaviour that existed prior to the Bootstrap update. However it is kind of random behaviour, the song that is played when the librarian open the circ page is different if the user has waiting holds or not. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index d4f2b0261f..c31e66bd86 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -963,7 +963,7 @@ -[% #IF waiting_holds.count > 0 %] +[% IF waiting_holds.count > 0 %] -[% #END %] +[% END %] [% INCLUDE modals/cancel_booking.inc %] [% MACRO jsinclude BLOCK %]