Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30756: Ground work for improving Koha_Authority.t

Browse source 
Move stuff into two subtests.

Test plan:
Run t/db_dependent/Koha_Authority.t.
If you have no imported auths, you will still see skips.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2022-05-14 07:42:42 +00:00 committed by Tomas Cohen Arazi
parent b4ea3da6f1
commit 96867a4fdc
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 65 additions and 60 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

125
t/db_dependent/Koha_Authority.t
View file

@ -18,85 +18,90 @@
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 3;
use File::Basename;
use MARC::Batch;
use MARC::File;
use IO::File;
use C4::Context;
use C4::Charset qw( MarcToUTF8Record );
use C4::AuthoritiesMarc qw( AddAuthority );
use Koha::Database;
use Test::More;
use File::Basename;
use MARC::Batch;
use MARC::File;
use IO::File;
use Koha::Authorities;
BEGIN {
use_ok('Koha::MetadataRecord::Authority');
}
my $schema = Koha::Database->new->schema;
our $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;
our $dbh = C4::Context->dbh;
# TODO Move this part to a t/lib packages
my $sourcedir = dirname(__FILE__) . "/data";
my $input_marc_file = "$sourcedir/marc21/zebraexport/authority/exported_records";
subtest 'Part 1' => sub {
# TODO Move this part to a t/lib packages
my $sourcedir = dirname(__FILE__) . "/data";
my $input_marc_file = "$sourcedir/marc21/zebraexport/authority/exported_records";
my $fh = IO::File->new($input_marc_file);
my $batch = MARC::Batch->new( 'USMARC', $fh );
while ( my $record = $batch->next ) {
C4::Charset::MarcToUTF8Record($record, 'MARC21');
AddAuthority($record, '', '');
}
my $record = MARC::Record->new;
$record->add_fields(
[ '001', '1234' ],
[ '150', ' ', ' ', a => 'Cooking' ],
[ '450', ' ', ' ', a => 'Cookery' ],
);
my $authority = Koha::MetadataRecord::Authority->new($record);
is(ref($authority), 'Koha::MetadataRecord::Authority', 'Created valid Koha::MetadataRecord::Authority object');
is($authority->authorized_heading(), 'Cooking', 'Authorized heading was correct');
is_deeply($authority->record, $record, 'Saved record');
my $authid = Koha::Authorities->search->next->authid;
$authority = Koha::MetadataRecord::Authority->get_from_authid($authid);
is(ref($authority), 'Koha::MetadataRecord::Authority', 'Retrieved valid Koha::MetadataRecord::Authority object');
is($authority->authid, $authid, 'Object authid is correct');
is($authority->record->field('001')->data(), $authid, 'Retrieved correct record');
$authority = Koha::MetadataRecord::Authority->get_from_authid('alphabetsoup');
is($authority, undef, 'No invalid record is retrieved');
SKIP:
{
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare("SELECT import_record_id FROM import_records WHERE record_type = 'auth' LIMIT 1;");
$sth->execute();
my $import_record_id;
for my $row ($sth->fetchrow_hashref) {
$import_record_id = $row->{'import_record_id'};
my $fh = IO::File->new($input_marc_file);
my $batch = MARC::Batch->new( 'USMARC', $fh );
while ( my $record = $batch->next ) {
C4::Charset::MarcToUTF8Record($record, 'MARC21');
AddAuthority($record, '', '');
}
skip 'No authorities in reservoir', 3 unless $import_record_id;
$authority = Koha::MetadataRecord::Authority->get_from_breeding($import_record_id);
my $record = MARC::Record->new;
$record->add_fields(
[ '001', '1234' ],
[ '150', ' ', ' ', a => 'Cooking' ],
[ '450', ' ', ' ', a => 'Cookery' ],
);
my $authority = Koha::MetadataRecord::Authority->new($record);
is(ref($authority), 'Koha::MetadataRecord::Authority', 'Created valid Koha::MetadataRecord::Authority object');
is($authority->authorized_heading(), 'Cooking', 'Authorized heading was correct');
is_deeply($authority->record, $record, 'Saved record');
my $authid = Koha::Authorities->search->next->authid;
$authority = Koha::MetadataRecord::Authority->get_from_authid($authid);
is(ref($authority), 'Koha::MetadataRecord::Authority', 'Retrieved valid Koha::MetadataRecord::Authority object');
is($authority->authid, undef, 'Records in reservoir do not have an authid');
is($authority->authid, $authid, 'Object authid is correct');
is(ref($authority->record), 'MARC::Record', 'MARC record attached to authority');
is($authority->record->field('001')->data(), $authid, 'Retrieved correct record');
$authority = Koha::MetadataRecord::Authority->get_from_breeding('alphabetsoup');
is($authority, undef, 'No invalid record is retrieved from reservoir');
}
$authority = Koha::MetadataRecord::Authority->get_from_authid('alphabetsoup');
is($authority, undef, 'No invalid record is retrieved');
};
done_testing();
subtest 'Part2' => sub {
SKIP: {
my $sth = $dbh->prepare("SELECT import_record_id FROM import_records WHERE record_type = 'auth' LIMIT 1;");
$sth->execute();
my $import_record_id;
for my $row ($sth->fetchrow_hashref) {
$import_record_id = $row->{'import_record_id'};
}
skip 'No authorities in reservoir', 3 unless $import_record_id;
my $authority = Koha::MetadataRecord::Authority->get_from_breeding($import_record_id);
is(ref($authority), 'Koha::MetadataRecord::Authority', 'Retrieved valid Koha::MetadataRecord::Authority object');
is($authority->authid, undef, 'Records in reservoir do not have an authid');
is(ref($authority->record), 'MARC::Record', 'MARC record attached to authority');
$authority = Koha::MetadataRecord::Authority->get_from_breeding('alphabetsoup');
is($authority, undef, 'No invalid record is retrieved from reservoir');
}
done_testing();
};
$schema->storage->txn_rollback;