Browse Source

Bug 25898: Prohibit indirect object notation

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
tags/v20.11.00
Julian Maurice 11 months ago
parent
commit
96cc447045
100 changed files with 116 additions and 116 deletions
  1. +1
    -1
      .perlcriticrc
  2. +1
    -1
      C4/Auth.pm
  3. +1
    -1
      C4/AuthoritiesMarc.pm
  4. +3
    -3
      C4/Breeding.pm
  5. +1
    -1
      C4/Context.pm
  6. +2
    -2
      C4/InstallAuth.pm
  7. +1
    -1
      C4/Languages.pm
  8. +1
    -1
      C4/Record.pm
  9. +1
    -1
      C4/SIP/Sip/Configuration.pm
  10. +1
    -1
      C4/SIP/t/SIPtest.pm
  11. +1
    -1
      C4/SIP/xmlparse.pl
  12. +6
    -6
      C4/Search.pm
  13. +4
    -4
      C4/Service.pm
  14. +1
    -1
      Koha/Illrequest/Logger.pm
  15. +1
    -1
      Koha/OAI/Server/DeletedRecord.pm
  16. +1
    -1
      Koha/OAI/Server/GetRecord.pm
  17. +3
    -3
      Koha/OAI/Server/ListBase.pm
  18. +1
    -1
      Koha/OAI/Server/ListIdentifiers.pm
  19. +1
    -1
      Koha/OAI/Server/ListRecords.pm
  20. +1
    -1
      Koha/OAI/Server/ListSets.pm
  21. +1
    -1
      Koha/OAI/Server/Record.pm
  22. +1
    -1
      Koha/OAI/Server/Repository.pm
  23. +1
    -1
      Koha/Patron/Discharge.pm
  24. +1
    -1
      Koha/SuggestionEngine/Plugin/ExplodedTerms.pm
  25. +1
    -1
      Koha/pdfformat/layout2pages.pm
  26. +1
    -1
      Koha/pdfformat/layout2pagesde.pm
  27. +2
    -2
      Koha/pdfformat/layout3pages.pm
  28. +2
    -2
      Koha/pdfformat/layout3pagesfr.pm
  29. +2
    -2
      about.pl
  30. +1
    -1
      acqui/add_user_search.pl
  31. +1
    -1
      acqui/addorder.pl
  32. +1
    -1
      acqui/addorderiso2709.pl
  33. +1
    -1
      acqui/ajax-getauthvaluedropbox.pl
  34. +1
    -1
      acqui/basket.pl
  35. +1
    -1
      acqui/basketgroup.pl
  36. +1
    -1
      acqui/basketheader.pl
  37. +1
    -1
      acqui/cancelorder.pl
  38. +1
    -1
      acqui/check_budget_total.pl
  39. +1
    -1
      acqui/check_uniqueness.pl
  40. +1
    -1
      acqui/duplicate_orders.pl
  41. +1
    -1
      acqui/finishreceive.pl
  42. +1
    -1
      acqui/histsearch.pl
  43. +1
    -1
      acqui/invoice-files.pl
  44. +1
    -1
      acqui/invoice.pl
  45. +1
    -1
      acqui/lateorders-export.pl
  46. +1
    -1
      acqui/lateorders.pl
  47. +1
    -1
      acqui/modordernotes.pl
  48. +1
    -1
      acqui/neworderempty.pl
  49. +1
    -1
      acqui/newordersubscription.pl
  50. +1
    -1
      acqui/newordersuggestion.pl
  51. +1
    -1
      acqui/ordered.pl
  52. +1
    -1
      acqui/orderreceive.pl
  53. +1
    -1
      acqui/parcel.pl
  54. +1
    -1
      acqui/showorder.pl
  55. +1
    -1
      acqui/spent.pl
  56. +1
    -1
      acqui/transferorder.pl
  57. +1
    -1
      acqui/uncertainprice.pl
  58. +1
    -1
      acqui/updatesupplier.pl
  59. +1
    -1
      acqui/z3950_search.pl
  60. +1
    -1
      admin/add_user_search.pl
  61. +1
    -1
      admin/additional-fields.pl
  62. +1
    -1
      admin/admin-home.pl
  63. +1
    -1
      admin/adveditorshortcuts.pl
  64. +1
    -1
      admin/aqbudgetperiods.pl
  65. +1
    -1
      admin/aqbudgets.pl
  66. +1
    -1
      admin/aqcontract.pl
  67. +1
    -1
      admin/aqplan.pl
  68. +1
    -1
      admin/audio_alerts.pl
  69. +1
    -1
      admin/auth_subfields_structure.pl
  70. +1
    -1
      admin/auth_tag_structure.pl
  71. +1
    -1
      admin/authorised_values.pl
  72. +1
    -1
      admin/authtypes.pl
  73. +1
    -1
      admin/biblio_framework.pl
  74. +1
    -1
      admin/branch_transfer_limits.pl
  75. +1
    -1
      admin/categories.pl
  76. +1
    -1
      admin/check_budget_parent.pl
  77. +1
    -1
      admin/check_parent_total.pl
  78. +1
    -1
      admin/checkmarc.pl
  79. +1
    -1
      admin/cities.pl
  80. +1
    -1
      admin/classsources.pl
  81. +1
    -1
      admin/clone-rules.pl
  82. +1
    -1
      admin/columns_settings.pl
  83. +1
    -1
      admin/credit_types.pl
  84. +1
    -1
      admin/debit_types.pl
  85. +1
    -1
      admin/desks.pl
  86. +1
    -1
      admin/didyoumean.pl
  87. +1
    -1
      admin/import_export_framework.pl
  88. +1
    -1
      admin/item_circulation_alerts.pl
  89. +1
    -1
      admin/items_search_field.pl
  90. +1
    -1
      admin/items_search_fields.pl
  91. +1
    -1
      admin/itemtypes.pl
  92. +1
    -1
      admin/koha2marclinks.pl
  93. +1
    -1
      admin/library_groups.pl
  94. +1
    -1
      admin/localization.pl
  95. +1
    -1
      admin/marc_subfields_structure.pl
  96. +1
    -1
      admin/marctagstructure.pl
  97. +1
    -1
      admin/matching-rules.pl
  98. +1
    -1
      admin/oai_set_mappings.pl
  99. +1
    -1
      admin/oai_sets.pl
  100. +1
    -1
      admin/patron-attr-types.pl

+ 1
- 1
.perlcriticrc View File

@@ -1,5 +1,5 @@
severity = 5
include = ProhibitUnusedVariables
include = ProhibitUnusedVariables Objects::ProhibitIndirectSyntax
exclude = Miscellanea::RequireRcsKeywords

[Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval]


+ 1
- 1
C4/Auth.pm View File

@@ -1804,7 +1804,7 @@ sub _get_session_params {
sub get_session {
my $sessionID = shift;
my $params = _get_session_params();
return new CGI::Session( $params->{dsn}, $sessionID, $params->{dsn_args} );
return CGI::Session->new( $params->{dsn}, $sessionID, $params->{dsn_args} );
}




+ 1
- 1
C4/AuthoritiesMarc.pm View File

@@ -227,7 +227,7 @@ sub SearchAuthorities {
my @oAuth;
my $i;
$oAuth[0]=C4::Context->Zconn("authorityserver" , 1);
my $Anewq= new ZOOM::Query::PQF($query,$oAuth[0]);
my $Anewq= ZOOM::Query::PQF->new($query,$oAuth[0]);
my $oAResult;
$oAResult= $oAuth[0]->search($Anewq) ;
while (($i = ZOOM::event(\@oAuth)) != 0) {


+ 3
- 3
C4/Breeding.pm View File

@@ -159,7 +159,7 @@ sub Z3950Search {
$oResult[$s] =
$server->{servertype} eq 'zed'?
$oConnection[$s]->search_pqf( $server_zquery ):
$oConnection[$s]->search(new ZOOM::Query::CQL(
$oConnection[$s]->search(ZOOM::Query::CQL->new(
_translate_query( $server, $squery )));
$s++;
}
@@ -430,7 +430,7 @@ sub _isbn_replace {

sub _create_connection {
my ( $server ) = @_;
my $option1= new ZOOM::Options();
my $option1= ZOOM::Options->new();
$option1->option( 'async' => 1 );
$option1->option( 'elementSetName', 'F' );
$option1->option( 'preferredRecordSyntax', $server->{syntax} );
@@ -568,7 +568,7 @@ sub Z3950SearchAuth {
}
else {
$oResult[$s] = $oConnection[$s]->search(
new ZOOM::Query::CQL(_translate_query( $server, $squery ))
ZOOM::Query::CQL->new(_translate_query( $server, $squery ))
);
}
$encoding[$s] = ($server->{encoding}?$server->{encoding}:"iso-5426");


+ 1
- 1
C4/Context.pm View File

@@ -637,7 +637,7 @@ sub _new_Zconn {
my $password = $context->{"serverinfo"}->{$server}->{"password"};
eval {
# set options
my $o = new ZOOM::Options();
my $o = ZOOM::Options->new();
$o->option(user => $user) if $user && $password;
$o->option(password => $password) if $user && $password;
$o->option(async => 1) if $async;


+ 2
- 2
C4/InstallAuth.pm View File

@@ -243,7 +243,7 @@ sub checkauth {
if ( $sessionID = $query->cookie("CGISESSID") ) {
C4::Context->_new_userenv($sessionID);
my $session =
new CGI::Session( "driver:File;serializer:yaml", $sessionID,
CGI::Session->new( "driver:File;serializer:yaml", $sessionID,
{ Directory => $sessdir } );
if ( $session->param('cardnumber') ) {
C4::Context->set_userenv(
@@ -283,7 +283,7 @@ sub checkauth {
}
unless ($userid) {
my $session =
new CGI::Session( "driver:File;serializer:yaml", undef, { Directory => $sessdir } );
CGI::Session->new( "driver:File;serializer:yaml", undef, { Directory => $sessdir } );
$sessionID = $session->id;
$userid = $query->param('userid');
C4::Context->_new_userenv($sessionID);


+ 1
- 1
C4/Languages.pm View File

@@ -603,7 +603,7 @@ sub getlanguage {
return $cached if $cached;
}

$cgi //= new CGI;
$cgi //= CGI->new;
my $interface = C4::Context->interface;
my $theme = C4::Context->preference( ( $interface eq 'opac' ) ? 'opacthemes' : 'template' );
my $language;


+ 1
- 1
C4/Record.pm View File

@@ -375,7 +375,7 @@ sub marc2endnote {
Year => $marc_rec_obj->publication_date,
Abstract => $abstract,
};
my $style = new Biblio::EndnoteStyle();
my $style = Biblio::EndnoteStyle->new();
my $template;
$template.= "DB - DB\n" if C4::Context->preference("LibraryName");
$template.="T1 - Title\n" if $marc_rec_obj->title();


+ 1
- 1
C4/SIP/Sip/Configuration.pm View File

@@ -12,7 +12,7 @@ use XML::Simple qw(:strict);

use C4::SIP::Sip qw(siplog);

my $parser = new XML::Simple(
my $parser = XML::Simple->new(
KeyAttr => {
login => '+id',
institution => '+id',


+ 1
- 1
C4/SIP/t/SIPtest.pm View File

@@ -263,7 +263,7 @@ sub run_sip_tests {
$Sip::error_detection = 1;
$/ = "\015\012"; # must use correct record separator

$sock = new IO::Socket::INET(PeerAddr => $server,
$sock = IO::Socket::INET->new(PeerAddr => $server,
Type => SOCK_STREAM);

BAIL_OUT('failed to create connection to server') unless $sock;


+ 1
- 1
C4/SIP/xmlparse.pl View File

@@ -13,7 +13,7 @@ use English;
use XML::Simple qw(:strict);
use Data::Dumper;

my $parser = new XML::Simple( KeyAttr => { login => '+id',
my $parser = XML::Simple->new( KeyAttr => { login => '+id',
institution => '+id',
service => '+port', },
GroupTags => { listeners => 'service',


+ 6
- 6
C4/Search.pm View File

@@ -224,7 +224,7 @@ sub SimpleSearch {
eval {
$zconns[$i] = C4::Context->Zconn( $servers[$i], 1 );
$query =~ s/:/=/g unless $options{skip_normalize};
$zoom_queries[$i] = new ZOOM::Query::CCL2RPN( $query, $zconns[$i]);
$zoom_queries[$i] = ZOOM::Query::CCL2RPN->new( $query, $zconns[$i]);
$tmpresults[$i] = $zconns[$i]->search( $zoom_queries[$i] );

# error handling
@@ -337,18 +337,18 @@ sub getRecords {
if ($query_type) {
if ($query_type =~ /^ccl/) {
$query_to_use =~ s/\:/\=/g; # change : to = last minute (FIXME)
$results[$i] = $zconns[$i]->search(new ZOOM::Query::CCL2RPN($query_to_use, $zconns[$i]));
$results[$i] = $zconns[$i]->search(ZOOM::Query::CCL2RPN->new($query_to_use, $zconns[$i]));
} elsif ($query_type =~ /^cql/) {
$results[$i] = $zconns[$i]->search(new ZOOM::Query::CQL($query_to_use, $zconns[$i]));
$results[$i] = $zconns[$i]->search(ZOOM::Query::CQL->new($query_to_use, $zconns[$i]));
} elsif ($query_type =~ /^pqf/) {
$results[$i] = $zconns[$i]->search(new ZOOM::Query::PQF($query_to_use, $zconns[$i]));
$results[$i] = $zconns[$i]->search(ZOOM::Query::PQF->new($query_to_use, $zconns[$i]));
} else {
warn "Unknown query_type '$query_type'. Results undetermined.";
}
} elsif ($scan) {
$results[$i] = $zconns[$i]->scan( new ZOOM::Query::CCL2RPN($query_to_use, $zconns[$i]));
$results[$i] = $zconns[$i]->scan( ZOOM::Query::CCL2RPN->new($query_to_use, $zconns[$i]));
} else {
$results[$i] = $zconns[$i]->search(new ZOOM::Query::CCL2RPN($query_to_use, $zconns[$i]));
$results[$i] = $zconns[$i]->search(ZOOM::Query::CCL2RPN->new($query_to_use, $zconns[$i]));
}
};
if ($@) {


+ 4
- 4
C4/Service.pm View File

@@ -86,7 +86,7 @@ passed to C<return_success()>.
sub init {
my ( $class, %needed_flags ) = @_;

our $query = new CGI;
our $query = CGI->new;

my ( $status, $cookie_, $sessionID ) = check_api_auth( $query, \%needed_flags );

@@ -94,7 +94,7 @@ sub init {

$class->return_error( 'auth', $status ) if ( $status ne 'ok' );

return ( $query, new C4::Output::JSONStream );
return ( $query, C4::Output::JSONStream->new );
}

=head2 return_error
@@ -119,7 +119,7 @@ param => value pairs.
sub return_error {
my ( $class, $type, $error, %flags ) = @_;

my $response = new C4::Output::JSONStream;
my $response = C4::Output::JSONStream->new;

$response->param( message => $error ) if ( $error );
$response->param( type => $type, %flags );
@@ -152,7 +152,7 @@ structure verbatim.
sub return_multi {
my ( $class, $responses, @flags ) = @_;

my $response = new C4::Output::JSONStream;
my $response = C4::Output::JSONStream->new;

if ( !@$responses ) {
$class->return_success( $response );


+ 1
- 1
Koha/Illrequest/Logger.pm View File

@@ -65,7 +65,7 @@ sub new {
}
};

my $query = new CGI; # To keep C4::Templates::_get_template_file() from complaining
my $query = CGI->new; # To keep C4::Templates::_get_template_file() from complaining
my ( $htdocs, $theme, $lang, $base ) =
C4::Templates::_get_template_file('ill/log/', 'intranet', $query);



+ 1
- 1
Koha/OAI/Server/DeletedRecord.pm View File

@@ -30,7 +30,7 @@ sub new {
my $self = $class->SUPER::new(%args);

$timestamp =~ s/ /T/, $timestamp .= 'Z';
$self->header( new HTTP::OAI::Header(
$self->header( HTTP::OAI::Header->new(
status => 'deleted',
identifier => $args{identifier},
datestamp => $timestamp,


+ 1
- 1
Koha/OAI/Server/GetRecord.pm View File

@@ -92,7 +92,7 @@ sub new {
{
return HTTP::OAI::Response->new(
requestURL => $repository->self_url(),
errors => [ new HTTP::OAI::Error(
errors => [ HTTP::OAI::Error->new(
code => 'idDoesNotExist',
message => "There is no biblio record with this identifier",
) ],


+ 3
- 3
Koha/OAI/Server/ListBase.pm View File

@@ -39,7 +39,7 @@ use MARC::File::XML;
sub GetRecords {
my ($class, $self, $repository, $metadata, %args) = @_;

my $token = new Koha::OAI::Server::ResumptionToken( %args );
my $token = Koha::OAI::Server::ResumptionToken->new( %args );
my $dbh = C4::Context->dbh;
my $set;
if ( defined $token->{'set'} ) {
@@ -127,7 +127,7 @@ sub GetRecords {
$count++;
if ( $count > $max ) {
$self->resumptionToken(
new Koha::OAI::Server::ResumptionToken(
Koha::OAI::Server::ResumptionToken->new(
metadataPrefix => $token->{metadata_prefix},
from => $token->{from},
until => $token->{until},
@@ -165,7 +165,7 @@ sub GetRecords {
} else {
$timestamp =~ s/ /T/;
$timestamp .= 'Z';
$self->identifier( new HTTP::OAI::Header(
$self->identifier( HTTP::OAI::Header->new(
identifier => $repository->{ koha_identifier} . ':' . $biblionumber,
datestamp => $timestamp,
status => $deleted ? 'deleted' : undef


+ 1
- 1
Koha/OAI/Server/ListIdentifiers.pm View File

@@ -35,7 +35,7 @@ sub new {
unless ($count) {
return HTTP::OAI::Response->new(
requestURL => $repository->self_url(),
errors => [ new HTTP::OAI::Error( code => 'noRecordsMatch' ) ],
errors => [ HTTP::OAI::Error->new( code => 'noRecordsMatch' ) ],
);
}



+ 1
- 1
Koha/OAI/Server/ListRecords.pm View File

@@ -35,7 +35,7 @@ sub new {
unless ($count) {
return HTTP::OAI::Response->new(
requestURL => $repository->self_url(),
errors => [ new HTTP::OAI::Error( code => 'noRecordsMatch' ) ],
errors => [ HTTP::OAI::Error->new( code => 'noRecordsMatch' ) ],
);
}



+ 1
- 1
Koha/OAI/Server/ListSets.pm View File

@@ -54,7 +54,7 @@ sub new {
}

$self->resumptionToken(
new Koha::OAI::Server::ResumptionToken(
Koha::OAI::Server::ResumptionToken->new(
metadataPrefix => $token->{metadata_prefix},
offset => $pos
)


+ 1
- 1
Koha/OAI/Server/Record.pm View File

@@ -32,7 +32,7 @@ sub new {
my $self = $class->SUPER::new(%args);

$timestamp =~ s/ /T/, $timestamp .= 'Z';
$self->header( new HTTP::OAI::Header(
$self->header( HTTP::OAI::Header->new(
identifier => $args{identifier},
datestamp => $timestamp,
) );


+ 1
- 1
Koha/OAI/Server/Repository.pm View File

@@ -127,7 +127,7 @@ sub new {
# Is metadataPrefix supported by the repository?
my $mdp = param('metadataPrefix') || '';
if ( $mdp && !grep { $_ eq $mdp } @{$self->{ koha_metadata_format }} ) {
push @errs, new HTTP::OAI::Error(
push @errs, HTTP::OAI::Error->new(
code => 'cannotDisseminateFormat',
message => "Dissemination as '$mdp' is not supported",
);


+ 1
- 1
Koha/Patron/Discharge.pm View File

@@ -118,7 +118,7 @@ sub generate_as_pdf {
$letter->{'title'} =~ s/<<today>>/$today/g;
$letter->{'content'} =~ s/<<today>>/$today/g;

my $tmpl = C4::Templates::gettemplate('batch/print-notices.tt', 'intranet', new CGI);
my $tmpl = C4::Templates::gettemplate('batch/print-notices.tt', 'intranet', CGI->new);
$tmpl->param(
stylesheet => C4::Context->preference("NoticeCSS"),
today => $today,


+ 1
- 1
Koha/SuggestionEngine/Plugin/ExplodedTerms.pm View File

@@ -79,7 +79,7 @@ sub get_suggestions {
'su-br',
'su-rl'
);
my $cgi = new CGI;
my $cgi = CGI->new;
my $template = C4::Templates::gettemplate('text/explodedterms.tt', 'opac', $cgi);
my @results;
foreach my $index (@indexes) {


+ 1
- 1
Koha/pdfformat/layout2pages.pm View File

@@ -57,7 +57,7 @@ sub printorders {
$pdf->mediabox($height/mm, $width/mm);
my $page = $pdf->page();
my $pdftable = new PDF::Table();
my $pdftable = PDF::Table->new();
my $abaskets;
my $arrbasket;


+ 1
- 1
Koha/pdfformat/layout2pagesde.pm View File

@@ -57,7 +57,7 @@ sub printorders {
$pdf->mediabox($height/mm, $width/mm);
my $page = $pdf->page();
my $pdftable = new PDF::Table();
my $pdftable = PDF::Table->new();
my $abaskets;
my $arrbasket;


+ 2
- 2
Koha/pdfformat/layout3pages.pm View File

@@ -82,7 +82,7 @@ sub printorders {
. ( $delivery_library ? "delivery at " . $delivery_library->branchname : "" )
);

my $pdftable = new PDF::Table();
my $pdftable = PDF::Table->new();
my $abaskets;
my $arrbasket;
my @keys = ('Document', 'Qty', 'RRP tax exc.', 'RRP tax inc.', 'Discount', 'Discount price', 'Tax rate', 'Total tax exc.', 'Total tax inc.');
@@ -200,7 +200,7 @@ sub printbaskets {
$text->font( $pdf->corefont("Times", -encoding => "utf8"), 6/mm );
$text->translate(30/mm, ($height-28.5)/mm);
$text->text($libraryname);
my $pdftable = new PDF::Table();
my $pdftable = PDF::Table->new();
my $abaskets;
my $arrbasket;
# header of the table


+ 2
- 2
Koha/pdfformat/layout3pagesfr.pm View File

@@ -82,7 +82,7 @@ sub printorders {
. ( $delivery_library ? "livraison à " . $delivery_library->branchname : "" )
);

my $pdftable = new PDF::Table();
my $pdftable = PDF::Table->new();
my $abaskets;
my $arrbasket;
my @keys = ('Document', 'Qté', 'Prix', 'Prix net', '% Remise', 'Remise', 'Taux TVA', 'Total HT', 'Total TTC');
@@ -201,7 +201,7 @@ sub printbaskets {
$text->font( $pdf->corefont("Times", -encoding => "utf8"), 6/mm );
$text->translate(30/mm, ($height-28.5)/mm);
$text->text($libraryname);
my $pdftable = new PDF::Table();
my $pdftable = PDF::Table->new();
my $abaskets;
my $arrbasket;
# header of the table


+ 2
- 2
about.pl View File

@@ -60,7 +60,7 @@ use C4::Members::Statistics;

#use Smart::Comments '####';

my $query = new CGI;
my $query = CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "about.tt",
@@ -208,7 +208,7 @@ my $warnNoActiveCurrency = (! defined Koha::Acquisition::Currencies->get_active)

my @xml_config_warnings;

my $context = new C4::Context;
my $context = C4::Context->new;

if ( C4::Context->config('zebra_bib_index_mode')
and C4::Context->config('zebra_bib_index_mode') eq 'grs1' )


+ 1
- 1
acqui/add_user_search.pl View File

@@ -26,7 +26,7 @@ use C4::Members;

use Koha::Patron::Categories;

my $input = new CGI;
my $input = CGI->new;

my $dbh = C4::Context->dbh;



+ 1
- 1
acqui/addorder.pl View File

@@ -135,7 +135,7 @@ use C4::Barcodes;
# FIXME: This needs to do actual error checking and possibly return user to the same form,
# not just blindly call C4 functions and print a redirect.

my $input = new CGI;
my $input = CGI->new;
my $use_ACQ_framework = $input->param('use_ACQ_framework');

# Check if order total amount exceed allowed budget


+ 1
- 1
acqui/addorderiso2709.pl View File

@@ -50,7 +50,7 @@ use Koha::Acquisition::Orders;
use Koha::Acquisition::Booksellers;
use Koha::Patrons;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie, $userflags) = get_template_and_user({
template_name => "acqui/addorderiso2709.tt",
query => $input,


+ 1
- 1
acqui/ajax-getauthvaluedropbox.pl View File

@@ -62,7 +62,7 @@ unless ($status eq "ok") {
exit 0;
}

my $input = new CGI;
my $input = CGI->new;
my $name = $input->param('name');
my $category = $input->param('category');
my $default = $input->param('default');


+ 1
- 1
acqui/basket.pl View File

@@ -74,7 +74,7 @@ the supplier this script have to display the basket.

=cut

our $query = new CGI;
our $query = CGI->new;
our $basketno = $query->param('basketno');
our $ean = $query->param('ean');
our $booksellerid = $query->param('booksellerid');


+ 1
- 1
acqui/basketgroup.pl View File

@@ -59,7 +59,7 @@ use Koha::Acquisition::Booksellers;
use Koha::ItemTypes;
use Koha::Patrons;

our $input=new CGI;
our $input=CGI->new;

our ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "acqui/basketgroup.tt",


+ 1
- 1
acqui/basketheader.pl View File

@@ -57,7 +57,7 @@ use Koha::Acquisition::Booksellers;
use Koha::Acquisition::Baskets;
use Koha::AdditionalFields;

my $input = new CGI;
my $input = CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "acqui/basketheader.tt",


+ 1
- 1
acqui/cancelorder.pl View File

@@ -37,7 +37,7 @@ use C4::Output;
use C4::Acquisition;
use Koha::Acquisition::Baskets;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
template_name => 'acqui/cancelorder.tt',
query => $input,


+ 1
- 1
acqui/check_budget_total.pl View File

@@ -30,7 +30,7 @@ fetches the budget amount fron the DB

=cut

my $input = new CGI;
my $input = CGI->new;
my $budget_id = $input->param('budget_id');
my $total = $input->param('total');



+ 1
- 1
acqui/check_uniqueness.pl View File

@@ -36,7 +36,7 @@ use JSON;
use C4::Output;
use C4::Items;

my $input = new CGI;
my $input = CGI->new;
my @field = $input->multi_param('field[]');
my @value = $input->multi_param('value[]');



+ 1
- 1
acqui/duplicate_orders.pl View File

@@ -30,7 +30,7 @@ use Koha::Acquisition::Currencies;
use Koha::Acquisition::Orders;
use Koha::DateUtils qw(dt_from_string output_pref);

my $input = new CGI;
my $input = CGI->new;
my $basketno = $input->param('basketno');
my $op = $input->param('op') || 'search'; # search, select, batch_edit



+ 1
- 1
acqui/finishreceive.pl View File

@@ -36,7 +36,7 @@ use Koha::Acquisition::Orders;

use List::MoreUtils qw/any/;

my $input=new CGI;
my $input=CGI->new;
my $flagsrequired = {acquisition => 'order_receive'};

checkauth($input, 0, $flagsrequired, 'intranet');


+ 1
- 1
acqui/histsearch.pl View File

@@ -59,7 +59,7 @@ use C4::Koha;
use Koha::AdditionalFields;
use Koha::DateUtils;

my $input = new CGI;
my $input = CGI->new;
my $do_search = $input->param('do_search') || 0;

my $dbh = C4::Context->dbh;


+ 1
- 1
acqui/invoice-files.pl View File

@@ -35,7 +35,7 @@ use C4::Output;
use C4::Acquisition;
use Koha::Misc::Files;

my $input = new CGI;
my $input = CGI->new;
my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
{
template_name => 'acqui/invoice-files.tt',


+ 1
- 1
acqui/invoice.pl View File

@@ -40,7 +40,7 @@ use Koha::DateUtils;
use Koha::Misc::Files;
use Koha::Acquisition::Invoice::Adjustments;

my $input = new CGI;
my $input = CGI->new;
my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
{
template_name => 'acqui/invoice.tt',


+ 1
- 1
acqui/lateorders-export.pl View File

@@ -24,7 +24,7 @@ use C4::Acquisition;
use C4::Output;
use C4::Context;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie) = get_template_and_user({
template_name => "acqui/csv/lateorders.tt",
query => $input,


+ 1
- 1
acqui/lateorders.pl View File

@@ -55,7 +55,7 @@ use Koha::DateUtils;
use Koha::Acquisition::Orders;
use Koha::CsvProfiles;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie) = get_template_and_user(
{
template_name => "acqui/lateorders.tt",


+ 1
- 1
acqui/modordernotes.pl View File

@@ -35,7 +35,7 @@ use C4::Acquisition;

use Koha::Acquisition::Booksellers;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
template_name => 'acqui/modordernotes.tt',
query => $input,


+ 1
- 1
acqui/neworderempty.pl View File

@@ -94,7 +94,7 @@ use Koha::Patrons;
use Koha::RecordProcessor;
use Koha::Subscriptions;

our $input = new CGI;
our $input = CGI->new;
my $booksellerid = $input->param('booksellerid'); # FIXME: else ERROR!
my $budget_id = $input->param('budget_id') || 0;
my $title = $input->param('title');


+ 1
- 1
acqui/newordersubscription.pl View File

@@ -27,7 +27,7 @@ use C4::Serials;

use Koha::Acquisition::Booksellers;

my $query = new CGI;
my $query = CGI->new;
my $title = $query->param('title_filter');
my $ISSN = $query->param('ISSN_filter');
my $EAN = $query->param('EAN_filter');


+ 1
- 1
acqui/newordersuggestion.pl View File

@@ -99,7 +99,7 @@ use C4::Budgets;

use Koha::Acquisition::Booksellers;

my $input = new CGI;
my $input = CGI->new;

# getting the CGI params
my $basketno = $input->param('basketno');


+ 1
- 1
acqui/ordered.pl View File

@@ -36,7 +36,7 @@ use Koha::Acquisition::Invoice::Adjustments;
use C4::Acquisition;

my $dbh = C4::Context->dbh;
my $input = new CGI;
my $input = CGI->new;
my $fund_id = $input->param('fund');
my $fund_code = $input->param('fund_code');



+ 1
- 1
acqui/orderreceive.pl View File

@@ -79,7 +79,7 @@ use Koha::DateUtils qw( dt_from_string );
use Koha::ItemTypes;
use Koha::Patrons;

my $input = new CGI;
my $input = CGI->new;

my $dbh = C4::Context->dbh;
my $invoiceid = $input->param('invoiceid');


+ 1
- 1
acqui/parcel.pl View File

@@ -74,7 +74,7 @@ use Koha::Biblios;

use JSON;

my $input=new CGI;
my $input=CGI->new;
my $sticky_filters = $input->param('sticky_filters') || 0;

my ($template, $loggedinuser, $cookie)


+ 1
- 1
acqui/showorder.pl View File

@@ -24,7 +24,7 @@ use C4::Output;
use Koha::Acquisition::Orders;
use Koha::Patrons;

my $cgi = new CGI;
my $cgi = CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user({
template_name => "acqui/showorder.tt",
query => $cgi,


+ 1
- 1
acqui/spent.pl View File

@@ -38,7 +38,7 @@ use C4::Acquisition;
use Koha::Acquisition::Invoice::Adjustments;

my $dbh = C4::Context->dbh;
my $input = new CGI;
my $input = CGI->new;
my $bookfund = $input->param('fund');
my $fund_code = $input->param('fund_code');



+ 1
- 1
acqui/transferorder.pl View File

@@ -28,7 +28,7 @@ use C4::Context;
use C4::Acquisition;
use Koha::Acquisition::Booksellers;

my $input = new CGI;
my $input = CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{ template_name => "acqui/transferorder.tt",
query => $input,


+ 1
- 1
acqui/uncertainprice.pl View File

@@ -55,7 +55,7 @@ use C4::Biblio qw/GetBiblioData/;
use Koha::Acquisition::Booksellers;
use Koha::Acquisition::Baskets;

my $input=new CGI;
my $input=CGI->new;

my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "acqui/uncertainprice.tt",


+ 1
- 1
acqui/updatesupplier.pl View File

@@ -58,7 +58,7 @@ use Koha::Acquisition::Bookseller::Contacts;
use Koha::Acquisition::Booksellers;
use CGI qw ( -utf8 );

my $input=new CGI;
my $input=CGI->new;

checkauth( $input, 0, { acquisition => 'vendors_manage' }, 'intranet' );



+ 1
- 1
acqui/z3950_search.pl View File

@@ -31,7 +31,7 @@ use C4::Koha;
use Koha::Acquisition::Booksellers;
use Koha::BiblioFrameworks;

my $input = new CGI;
my $input = CGI->new;
my $biblionumber = $input->param('biblionumber')||0;
my $frameworkcode = $input->param('frameworkcode') || q{};
my $title = $input->param('title');


+ 1
- 1
admin/add_user_search.pl View File

@@ -26,7 +26,7 @@ use C4::Members;

use Koha::Patron::Categories;

my $input = new CGI;
my $input = CGI->new;

my $dbh = C4::Context->dbh;



+ 1
- 1
admin/additional-fields.pl View File

@@ -23,7 +23,7 @@ use C4::Koha;
use C4::Output;
use Koha::AdditionalFields;

my $input = new CGI;
my $input = CGI->new;

my %flagsrequired;
$flagsrequired{parameters} = 'manage_additional_fields';


+ 1
- 1
admin/admin-home.pl View File

@@ -22,7 +22,7 @@ use C4::Auth;
use C4::Output;
use Koha::Plugins;

my $query = new CGI;
my $query = CGI->new;

my $plugins_enabled = C4::Context->config("enable_plugins");
my $mana_url = C4::Context->config('mana_config');


+ 1
- 1
admin/adveditorshortcuts.pl View File

@@ -43,7 +43,7 @@ use CGI qw ( -utf8 );
use C4::Koha;
use Koha::KeyboardShortcuts;

my $input = new CGI;
my $input = CGI->new;
my $op = $input->param('op') || 'list';

my ( $template, $loggedinuser, $cookie ) = get_template_and_user(


+ 1
- 1
admin/aqbudgetperiods.pl View File

@@ -61,7 +61,7 @@ use Koha::Acquisition::Currencies;

my $dbh = C4::Context->dbh;

my $input = new CGI;
my $input = CGI->new;

my $searchfield = $input->param('searchfield') // '';
my $budget_period_id = $input->param('budget_period_id');


+ 1
- 1
admin/aqbudgets.pl View File

@@ -36,7 +36,7 @@ use C4::Debug;
use Koha::Acquisition::Currencies;
use Koha::Patrons;

my $input = new CGI;
my $input = CGI->new;
my $dbh = C4::Context->dbh;

my ($template, $borrowernumber, $cookie, $staffflags ) = get_template_and_user(


+ 1
- 1
admin/aqcontract.pl View File

@@ -30,7 +30,7 @@ use Koha::DateUtils;

use Koha::Acquisition::Booksellers;

my $input = new CGI;
my $input = CGI->new;
my $contractnumber = $input->param('contractnumber');
my $booksellerid = $input->param('booksellerid');
my $op = $input->param('op') || 'list';


+ 1
- 1
admin/aqplan.pl View File

@@ -36,7 +36,7 @@ use C4::Auth;
use C4::Debug;
use Koha::Acquisition::Currencies;

our $input = new CGI;
our $input = CGI->new;
#### $input

my $dbh = C4::Context->dbh;


+ 1
- 1
admin/audio_alerts.pl View File

@@ -25,7 +25,7 @@ use C4::Output;
use Koha::AudioAlert;
use Koha::AudioAlerts;

my $cgi = new CGI;
my $cgi = CGI->new;

my $selector = $cgi->param('selector');
my $sound = $cgi->param('sound');


+ 1
- 1
admin/auth_subfields_structure.pl View File

@@ -48,7 +48,7 @@ sub auth_subfield_structure_exists {
return @$rows > 0;
}

my $input = new CGI;
my $input = CGI->new;
my $tagfield = $input->param('tagfield');
my $tagsubfield = $input->param('tagsubfield');
my $authtypecode = $input->param('authtypecode');


+ 1
- 1
admin/auth_tag_structure.pl View File

@@ -29,7 +29,7 @@ use C4::Context;
use Koha::Authority::Types;

# retrieve parameters
my $input = new CGI;
my $input = CGI->new;
my $authtypecode = $input->param('authtypecode') || ''; # set to select framework
my $existingauthtypecode = $input->param('existingauthtypecode') || ''; # set when we have to create a new framework (in authtype) by copying an old one (in existingauthtype)



+ 1
- 1
admin/authorised_values.pl View File

@@ -31,7 +31,7 @@ use Koha::AuthorisedValues;
use Koha::AuthorisedValueCategories;
use Koha::Libraries;

my $input = new CGI;
my $input = CGI->new;
my $id = $input->param('id');
my $op = $input->param('op') || 'list';
my $searchfield = $input->param('searchfield');


+ 1
- 1
admin/authtypes.pl View File

@@ -28,7 +28,7 @@ use C4::Output;
use Koha::Authorities;
use Koha::Authority::Types;

my $input = new CGI;
my $input = CGI->new;
my $authtypecode = $input->param('authtypecode');
my $op = $input->param('op') || 'list';
my @messages;


+ 1
- 1
admin/biblio_framework.pl View File

@@ -28,7 +28,7 @@ use Koha::BiblioFramework;
use Koha::BiblioFrameworks;
use Koha::Caches;

my $input = new CGI;
my $input = CGI->new;
my $frameworkcode = $input->param('frameworkcode') || q||;
my $op = $input->param('op') || q|list|;
my $cache = Koha::Caches->get_instance();


+ 1
- 1
admin/branch_transfer_limits.pl View File

@@ -27,7 +27,7 @@ use C4::Output;
use C4::Koha;
use C4::Circulation qw{ IsBranchTransferAllowed DeleteBranchTransferLimits CreateBranchTransferLimit };

my $input = new CGI;
my $input = CGI->new;

my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "admin/branch_transfer_limits.tt",


+ 1
- 1
admin/categories.pl View File

@@ -31,7 +31,7 @@ use Koha::DateUtils;
use Koha::Patron::Categories;
use Koha::Libraries;

my $input = new CGI;
my $input = CGI->new;
my $searchfield = $input->param('description') // q||;
my $categorycode = $input->param('categorycode');
my $op = $input->param('op') // 'list';


+ 1
- 1
admin/check_budget_parent.pl View File

@@ -31,7 +31,7 @@ called by aqbudgets.pl and neworderempty.pl

=cut

my $input = new CGI;
my $input = CGI->new;

my $budget_id = $input->param('budget_id');
my $new_parent_id = $input->param('new_parent');


+ 1
- 1
admin/check_parent_total.pl View File

@@ -34,7 +34,7 @@ to determine whether the new parent budget (or period) has enough unallocated fu
=cut

my $dbh = C4::Context->dbh;
my $input = new CGI;
my $input = CGI->new;

my $total = $input->param('total');
my $budget_id = $input->param('budget_id');


+ 1
- 1
admin/checkmarc.pl View File

@@ -26,7 +26,7 @@ use C4::Context;
use C4::Biblio;


my $input = new CGI;
my $input = CGI->new;

my ($template, $borrowernumber, $cookie)
= get_template_and_user({template_name => "admin/checkmarc.tt",


+ 1
- 1
admin/cities.pl View File

@@ -26,7 +26,7 @@ use C4::Output;

use Koha::Cities;

my $input = new CGI;
my $input = CGI->new;
my $city_name_filter = $input->param('city_name_filter') // q||;
my $cityid = $input->param('cityid');
my $op = $input->param('op') || 'list';


+ 1
- 1
admin/classsources.pl View File

@@ -33,7 +33,7 @@ use Koha::ClassSplitRules;

my $script_name = "/cgi-bin/koha/admin/classsources.pl";

my $input = new CGI;
my $input = CGI->new;
my $op = $input->param('op') || 'list';
my $cn_source = $input->param('cn_source');
my $class_sort_rule = $input->param('class_sort_rule');


+ 1
- 1
admin/clone-rules.pl View File

@@ -34,7 +34,7 @@ use C4::Koha;
use C4::Debug;
use Koha::CirculationRules;

my $input = new CGI;
my $input = CGI->new;

my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "admin/clone-rules.tt",


+ 1
- 1
admin/columns_settings.pl View File

@@ -7,7 +7,7 @@ use C4::Auth;
use C4::Context;
use C4::Output;
use C4::Utils::DataTables::TablesSettings qw( get_modules );
my $input = new CGI;
my $input = CGI->new;

my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{


+ 1
- 1
admin/credit_types.pl View File

@@ -28,7 +28,7 @@ use C4::Output;
use Koha::Account::CreditType;
use Koha::Account::CreditTypes;

my $input = new CGI;
my $input = CGI->new;
my $code = $input->param('code');
my $op = $input->param('op') || 'list';
my @messages;


+ 1
- 1
admin/debit_types.pl View File

@@ -28,7 +28,7 @@ use C4::Output;
use Koha::Account::DebitType;
use Koha::Account::DebitTypes;

my $input = new CGI;
my $input = CGI->new;
my $code = $input->param('code');
my $op = $input->param('op') || 'list';
my @messages;


+ 1
- 1
admin/desks.pl View File

@@ -26,7 +26,7 @@ use C4::Output;

use Koha::Desks;

my $input = new CGI;
my $input = CGI->new;
my $searchfield = $input->param('desk_name') // q||;
my $desk_id = $input->param('desk_id') || '';
my $op = $input->param('op') || 'list';


+ 1
- 1
admin/didyoumean.pl View File

@@ -9,7 +9,7 @@ use Koha::SuggestionEngine;
use Module::Load::Conditional qw(can_load);
use JSON;

my $input = new CGI;
my $input = CGI->new;

my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "admin/didyoumean.tt",


+ 1
- 1
admin/import_export_framework.pl View File

@@ -38,7 +38,7 @@ if ($auth_status eq 'ok') {
$authenticated = 1;
}

my $input = new CGI;
my $input = CGI->new;

unless ($authenticated) {
print $input->header(-type => 'text/plain', -status => '403 Forbidden');


+ 1
- 1
admin/item_circulation_alerts.pl View File

@@ -111,7 +111,7 @@ sub dispatch {
show => \&show,
toggle => \&toggle,
);
my $input = new CGI;
my $input = CGI->new;
my $action = $input->param('action') || 'show';
if (not exists $handler{$action}) {
my $status = 400;


+ 1
- 1
admin/items_search_field.pl View File

@@ -24,7 +24,7 @@ use C4::Output;

use Koha::Item::Search::Field qw(GetItemSearchField ModItemSearchField);

my $cgi = new CGI;
my $cgi = CGI->new;

my ($template, $borrowernumber, $cookie) = get_template_and_user({
template_name => 'admin/items_search_field.tt',


+ 1
- 1
admin/items_search_fields.pl View File

@@ -24,7 +24,7 @@ use C4::Output;

use Koha::Item::Search::Field qw(AddItemSearchField GetItemSearchFields DelItemSearchField);

my $cgi = new CGI;
my $cgi = CGI->new;

my ($template, $borrowernumber, $cookie) = get_template_and_user({
template_name => 'admin/items_search_fields.tt',


+ 1
- 1
admin/itemtypes.pl View File

@@ -35,7 +35,7 @@ use Koha::ItemTypes;
use Koha::ItemType;
use Koha::Localizations;

my $input = new CGI;
my $input = CGI->new;
my $searchfield = $input->param('description');
my $itemtype_code = $input->param('itemtype');
my $op = $input->param('op') // 'list';


+ 1
- 1
admin/koha2marclinks.pl View File

@@ -29,7 +29,7 @@ use Koha::BiblioFrameworks;
use Koha::Caches;
use Koha::MarcSubfieldStructures;

my $input = new CGI;
my $input = CGI->new;

my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
{


+ 1
- 1
admin/library_groups.pl View File

@@ -27,7 +27,7 @@ use Koha::Libraries;
use Koha::Library::Group;
use Koha::Library::Groups;

my $cgi = new CGI;
my $cgi = CGI->new;

my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{


+ 1
- 1
admin/localization.pl View File

@@ -26,7 +26,7 @@ use Koha::Localizations;

use CGI qw( -utf8 );

my $query = new CGI;
my $query = CGI->new;

my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
{ template_name => "admin/localization.tt",


+ 1
- 1
admin/marc_subfields_structure.pl View File

@@ -61,7 +61,7 @@ sub marc_subfield_structure_exists {
return @$rows > 0;
}

my $input = new CGI;
my $input = CGI->new;
my $tagfield = $input->param('tagfield');
my $tagsubfield = $input->param('tagsubfield');
my $frameworkcode = $input->param('frameworkcode');


+ 1
- 1
admin/marctagstructure.pl View File

@@ -31,7 +31,7 @@ use Koha::AuthorisedValues;
use Koha::BiblioFrameworks;

# retrieve parameters
my $input = new CGI;
my $input = CGI->new;
my $frameworkcode = $input->param('frameworkcode') || ''; # set to select framework
my $existingframeworkcode = $input->param('existingframeworkcode') || '';
my $searchfield = $input->param('searchfield') || 0;


+ 1
- 1
admin/matching-rules.pl View File

@@ -29,7 +29,7 @@ use C4::Matcher qw/valid_normalization_routines/;

my $script_name = "/cgi-bin/koha/admin/matching-rules.pl";

our $input = new CGI;
our $input = CGI->new;
my $op = $input->param('op') || '';




+ 1
- 1
admin/oai_set_mappings.pl View File

@@ -39,7 +39,7 @@ use C4::OAI::Sets;

use Data::Dumper;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
template_name => 'admin/oai_set_mappings.tt',
query => $input,


+ 1
- 1
admin/oai_sets.pl View File

@@ -35,7 +35,7 @@ use C4::OAI::Sets;

use Data::Dumper;

my $input = new CGI;
my $input = CGI->new;
my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
template_name => 'admin/oai_sets.tt',
query => $input,


+ 1
- 1
admin/patron-attr-types.pl View File

@@ -36,7 +36,7 @@ use Koha::Patron::Categories;

my $script_name = "/cgi-bin/koha/admin/patron-attr-types.pl";

our $input = new CGI;
our $input = CGI->new;
my $op = $input->param('op') || '';




Some files were not shown because too many files changed in this diff

Loading…
Cancel
Save