Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37165: Can't edit frequencies due to stray cud- in modify op

Browse source 
The op modify in subscription-frequencies.pl isn't a cud- operation, it's
a GET of the editing form, so it shouldn't have been changed to cud-modify.

Test plan:
1. Don't apply the patch yet
2. Serials - Manage frequencies - for any frequency click Edit
2. Note that the editing form is empty
3. Apply patch, restart_all
4. Repeat step 2, note that now the editing form has the existing data
5. Change anything, Display order is nice, and save to verify that
   cud-savemod still works

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Phil Ringnalda 2024-06-22 16:40:19 -07:00 committed by Katrin Fischer
parent fb9edbcf5c
commit 96d1ad65b4
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
serials/subscription-frequencies.pl
View file

@ -46,11 +46,11 @@ my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
my $op = $input->param('op'); my $op = $input->param('op');
if($op && ($op eq 'new' || $op eq 'cud-modify')) { if($op && ($op eq 'new' || $op eq 'modify')) {
my @units_loop; my @units_loop;
push @units_loop, {val => $_} for (qw/ day week month year /); push @units_loop, {val => $_} for (qw/ day week month year /);
if($op eq 'cud-modify') { if($op eq 'modify') {
my $frequencyid = $input->param('frequencyid'); my $frequencyid = $input->param('frequencyid');
my $frequency = GetSubscriptionFrequency($frequencyid); my $frequency = GetSubscriptionFrequency($frequencyid);
foreach (@units_loop) { foreach (@units_loop) {