Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34574: Add CSS class to datatable select filter

Browse source 
Test plan:

1) Create a new patron category, visit:
/cgi-bin/koha/admin/categories.pl?op=add_form
2) Add a category code, en enrollment period, a category type and a really long description like:
"This is a real long description of the patron category code for demo purposes"
3) Now do the same but for a library, visit:
/cgi-bin/koha/admin/branches.pl?op=add_form
4) Add a library code and a really long name like:
"This is a real long library name for demo purposes"
5) Visit patrons home:
/cgi-bin/koha/members/members-home.pl
6) Hit "Search". Notice the "library" and "category" columns grow in width to match the largest option (added in previous steps)
7) Apply patch, add the following CSS to IntranetUserCSS:
.dt-select-filter{
	max-width:200px;
}
8) repeat 5) and 6). Notice the columns no longer grow in width.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Pedro Amorim 2023-12-21 14:11:35 +00:00 committed by Katrin Fischer
parent 0f31a5c9bc
commit 99014e9395
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/js/datatables.js
View file

@ -838,7 +838,7 @@ function _dt_add_filters(table_node, table_dt, filters_options = {}) {
input_type = 'select'
let filter_type = $(this).data('filter');
let existing_search = table_dt.column(i).search();
let select = $('<select><option value=""></option></select');
let select = $('<select class="dt-select-filter"><option value=""></option></select');
// FIXME eval here is bad and dangerous, how do we workaround that?
if ( !filters_options.hasOwnProperty(i) ) {