Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21896: (QA follow-up) Document and Test for FIFO behaviour

Browse source 
A short dicussion lead to the decision to make it explictly clear that
this method will implicitly apply credits against debits in a 'First In
First Out' manor, meaning oldest outstanding debits will be paid off
first.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2018-11-29 13:49:27 +00:00 committed by Nick Clemens
parent 4302bdda5c
commit 99535e0fda
4 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Koha/Account.pm
View file

@ -519,7 +519,9 @@ sub lines {
$account->reconcile_balance();
Find outstanding credits and use them to pay outstanding debits
Find outstanding credits and use them to pay outstanding debits.
Currently, this implicitly uses the 'First In First Out' rule for
applying credits against debits.
=cut

8
Koha/Account/Line.pm
View file

@ -241,4 +241,12 @@ sub _type {
return 'Accountline';
}
=head3 object_class (internal)
=cut
sub object_class {
return 'Koha::Account::Line';
}
1;

7
Koha/Schema/Result/Accountline.pm
View file

@ -239,6 +239,11 @@ __PACKAGE__->belongs_to(
# Created by DBIx::Class::Schema::Loader v0.07042 @ 2018-05-16 17:00:24
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:pygYYKxFDRLX97PyeUeLvg
sub koha_objects_class {
'Koha::Account::Lines';
}
sub koha_object_class {
'Koha::Account::Line';
}
# You can replace this text with custom content, and it will be preserved on regeneration
1;

2
t/db_dependent/Koha/Account.t
View file

@ -269,7 +269,7 @@ subtest 'reconcile_balance' => sub {
$schema->storage->txn_rollback;
};
subtest 'same debit than credit' => sub {
subtest 'same debit as credit' => sub {
plan tests => 6;