Browse Source

Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron

This patch adds unit tests for Authenticate patron.

To test:
- Run perl t/db_dependent/ILSDI_Services.t
- Verify all tests pass

Note: there are some tests marked as TODO.

Rewriting AuthenticatePatron to make cardnumber and userid
work for authenticating a patron will be implemented in the
next patch. Tests related to this are currently showing as
'not ok', but are still passing.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors
With both patches applied, all test pass.
Signed-off-by: Mason James <mtj@kohaaloha.com>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
new/bootstrap-opac
Katrin Fischer 9 years ago
committed by Galen Charlton
parent
commit
995f4b6ecb
  1. 1
      C4/ILSDI/Services.pm
  2. 93
      t/db_dependent/ILSDI_Services.t

1
C4/ILSDI/Services.pm

@ -34,6 +34,7 @@ use XML::Simple;
use HTML::Entities;
use CGI;
use DateTime;
use C4::Auth;
=head1 NAME

93
t/db_dependent/ILSDI_Services.t

@ -0,0 +1,93 @@
#!/usr/bin/perl
use Modern::Perl;
use C4::Members qw/AddMember GetMember GetBorrowercategory/;
use C4::Branch;
use CGI;
use Test::More tests => 15;
BEGIN {
use_ok('C4::ILSDI::Services');
}
my $dbh = C4::Context->dbh;
# Start transaction
$dbh->{AutoCommit} = 0;
$dbh->{RaiseError} = 1;
# Create patron
my %data = (
firstname => 'my firstname',
surname => 'my surname',
categorycode => 'UT',
branchcode => 'UT',
cardnumber => 'ilsdi-cardnumber',
userid => 'ilsdi-userid',
password => 'ilsdi-password',
);
# Crate patron category
unless ( GetBorrowercategory('UT') ) {
$dbh->do("INSERT INTO categories
(categorycode,description,enrolmentperiod,upperagelimit,enrolmentfee,overduenoticerequired,reservefee,category_type)
VALUES
('UT','Unit tester',99,99,0.000000,1,0.000000,'C');");
}
# Create branch
unless ( GetBranchDetail('DEMO') ) {
$dbh->do("INSERT INTO branches (branchcode,branchname) VALUES ('UT','Unit test library');");
}
my $borrowernumber = AddMember(%data);
my $borrower = GetMember( borrowernumber => $borrowernumber );
{ # AuthenticatePatron test
my $query = new CGI;
$query->param('username',$borrower->{'userid'});
$query->param('password','ilsdi-password');
my $reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'id'}, $borrowernumber, "userid and password - Patron authenticated");
is($reply->{'code'}, undef, "Error code undef");
$query->param('password','ilsdi-passworD');
$reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'code'}, 'PatronNotFound', "userid and wrong password - PatronNotFound");
is($reply->{'id'}, undef, "id undef");
$query->param('password','ilsdi-password');
$query->param('username','wrong-ilsdi-useriD');
$reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'code'}, 'PatronNotFound', "non-existing userid - PatronNotFound");
is($reply->{'id'}, undef, "id undef");
$query->param('username',uc($borrower->{'userid'}));
$reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'id'}, $borrowernumber, "userid is not case sensitive - Patron authenticated");
is($reply->{'code'}, undef, "Error code undef");
TODO: { local: $TODO = "Can't use cardnumber for authentication with ILS-DI yet.";
$query->param('username',$borrower->{'cardnumber'});
$reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'id'}, $borrowernumber, "cardnumber and password - Patron authenticated");
is($reply->{'code'}, undef, "Error code undef");
$query->param('password','ilsdi-passworD');
$reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'code'}, 'PatronNotFound', "cardnumber and wrong password - PatronNotFount");
is($reply->{'id'}, undef, "id undef");
$query->param('username','randomcardnumber1234');
$query->param('password','ilsdi-password');
$reply = C4::ILSDI::Services::AuthenticatePatron($query);
is($reply->{'code'}, 'PatronNotFound', "non-existing cardnumer/userid - PatronNotFound");
is($reply->{'id'}, undef, "id undef");
}
}
Loading…
Cancel
Save