Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 9596: (QA follow-up) Only find a given patron once

Browse source 
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Kyle Hall 2024-07-23 06:39:07 -04:00 committed by Katrin Fischer
parent bbd722be5b
commit 99c2064126
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
misc/cronjobs/longoverdue.pl
View file

@ -464,15 +464,18 @@ foreach my $startrange (sort keys %$lost) {
$sth_items->execute($startrange, $endrange, $lostvalue);
$count=0;
ITEM: while (my $row=$sth_items->fetchrow_hashref) {
my $patron;
if( $filter_borrower_categories ) {
my $category = uc Koha::Patrons->find( $row->{borrowernumber} )->categorycode();
$patron ||= Koha::Patrons->find( $row->{borrowernumber} );
my $category = uc $patron->categorycode();
next ITEM unless ( $category_to_process{ $category } );
}
if ($filter_branches) {
my $lib;
for ($circ_control_pref) {
if ( $_ eq 'PatronLibrary' ) {
$lib = Koha::Patrons->find( $row->{borrowernumber} )->branchcode();
$patron ||= Koha::Patrons->find( $row->{borrowernumber} );
$lib = $patron->branchcode();
} elsif ( $_ eq 'PickupLibrary' ) {
$lib = C4::Context->userenv->{'branch'};
} else { # ( $_ eq 'ItemHomeLibrary' )
@ -492,7 +495,7 @@ foreach my $startrange (sort keys %$lost) {
if ( $charge && $charge eq $lostvalue ) {
LostItem( $row->{'itemnumber'}, 'cronjob', $mark_returned );
} elsif ( $mark_returned ) {
my $patron = Koha::Patrons->find( $row->{borrowernumber} );
$patron ||= Koha::Patrons->find( $row->{borrowernumber} );
MarkIssueReturned($row->{borrowernumber},$row->{itemnumber},undef,$patron->privacy)
}
}