Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18382: (QA follow-up) Replace ->ymd by ->datetime

Browse source 
The first patch makes Hold.t fail on:
not ok 8 - Hold is suspended with a date, truncation takes place automatically
   Failed test 'Hold is suspended with a date, truncation takes place automatically'
   at Hold.t line 94.
          got: '2018-03-22'
     expected: '2018-03-22T00:00:00'

We could remove the midnight time there, but we also could replace ymd by
datetime. The cpan doc tells us:
    Same as $dt->ymd('-') . 'T' . $dt->hms(':')

Test plan:
With this patch, run Hold.t again. It should pass now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2018-03-22 09:17:46 +01:00 committed by Jonathan Druart
parent 2deaead256
commit 9a07da768c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Hold.pm
View file

@ -92,7 +92,7 @@ sub suspend_hold {
$self->suspend(1);
if ( defined $dt ){
$self->suspend_until( $dt->ymd );
$self->suspend_until( $dt->datetime );
} else {
$self->suspend_until( $dt );
}