Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36758: (QA follow-up) Tidy Ticket.t

Browse source 
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Katrin Fischer 2024-08-09 15:55:37 +00:00
parent 4e99c1bc85
commit 9a8a534c8a
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 34 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
t/db_dependent/Koha/Ticket.t
View file

@ -258,7 +258,7 @@ subtest 'store() tests' => sub {
my $biblio = $builder->build_sample_biblio();
my $librarian = $builder->build_object( { class => "Koha::Patrons" } );
t::lib::Mocks::mock_userenv({ patron => $librarian });
t::lib::Mocks::mock_userenv( { patron => $librarian } );
my $new_ticket = Koha::Ticket->new(
{
@ -270,45 +270,53 @@ subtest 'store() tests' => sub {
}
)->store();
is( ref($new_ticket), 'Koha::Ticket',
'Koha::Ticket->store() returned the Koha::Ticket object' );
my $notices =
Koha::Notice::Messages->search( { borrowernumber => $assignee->id } );
is( $notices->count, 1,
'One assignment notice queued for the ticket assignee at ticket creation' );
is(
ref($new_ticket), 'Koha::Ticket',
'Koha::Ticket->store() returned the Koha::Ticket object'
);
my $notices = Koha::Notice::Messages->search( { borrowernumber => $assignee->id } );
is(
$notices->count, 1,
'One assignment notice queued for the ticket assignee at ticket creation'
);
my $THE_notice = $notices->next;
isnt( $THE_notice->status, 'pending',
'Assignment notice is sent immediately' );
isnt(
$THE_notice->status, 'pending',
'Assignment notice is sent immediately'
);
$new_ticket->set( { title => "Changed title" } )->store();
$notices =
Koha::Notice::Messages->search( { borrowernumber => $assignee->id } );
is( $notices->count, 1,
$notices = Koha::Notice::Messages->search( { borrowernumber => $assignee->id } );
is(
$notices->count, 1,
"Further assignment notices are not queud for subsequent stores that don't set assignee"
);
$new_ticket->set({ assignee_id => $assignee->id })->store();
$notices =
Koha::Notice::Messages->search( { borrowernumber => $assignee->id } );
is( $notices->count, 1,
$new_ticket->set( { assignee_id => $assignee->id } )->store();
$notices = Koha::Notice::Messages->search( { borrowernumber => $assignee->id } );
is(
$notices->count, 1,
"Further assignment notices are not queud for subsequent stores that don't change assignee"
);
my $assignee2 = $builder->build_object( { class => "Koha::Patrons" } );
$new_ticket->set({ assignee_id => $assignee2->id })->store();
$notices =
Koha::Notice::Messages->search( { borrowernumber => $assignee2->id } );
is( $notices->count, 1,
'New assignment notice queued for a change of ticket assignee' );
$new_ticket->set( { assignee_id => $assignee2->id } )->store();
$notices = Koha::Notice::Messages->search( { borrowernumber => $assignee2->id } );
is(
$notices->count, 1,
'New assignment notice queued for a change of ticket assignee'
);
$new_ticket->set({ assignee_id => $librarian->id })->store();
$notices =
Koha::Notice::Messages->search( { borrowernumber => $librarian->id } );
is( $notices->count, 0,
'Assignment notice not queued for self-assignments' );
$new_ticket->set( { assignee_id => $librarian->id } )->store();
$notices = Koha::Notice::Messages->search( { borrowernumber => $librarian->id } );
is(
$notices->count, 0,
'Assignment notice not queued for self-assignments'
);
$schema->storage->txn_rollback;
};
};
subtest 'strings_map() tests' => sub {