Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10694: (follow-up) fix problems with the new Borrowers plugin

Browse source 
TT plugins should *not* be duplicating business logic found
in other modules.  This patch replaces the copy-and-paste of the
old IsDebarred logic with a call to the appropriate routine and
updates the POD.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Galen Charlton 2014-05-02 22:46:23 +00:00
parent 80c68171bd
commit 9ab9686250
1 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Koha/Template/Plugin/Borrowers.pm
View file

@ -1,6 +1,7 @@
package Koha::Template::Plugin::Borrowers;
# Copyright ByWater Solutions 2013
# Copyright Equinox Software, Inc. 2014
# This file is part of Koha.
#
@ -21,9 +22,7 @@ use Modern::Perl;
use base qw( Template::Plugin );
use Date::Calc qw/Today Add_Delta_YM check_date Date_to_Days/;
use C4::Koha;
use Koha::Borrower::Debarments qw//;
=pod
@ -34,7 +33,7 @@ Templates when it makes sense to do so.
To use, first, include the line '[% USE Borrowers %]' at the top
of the template to enable the plugin.
For example: [% IF Borrowers.IsDebarred( borrower.borrowernumber ) %]
For example: [% IF Borrowers.IsDebarred( borrower ) %]
removes the necessity of setting a template variable in Perl code to
find out if a patron is restricted even if that variable is not evaluated
in any way in the script.
@ -46,13 +45,7 @@ sub IsDebarred {
return unless $borrower;
if ( $borrower->{'debarred'} && check_date( split( /-/, $borrower->{'debarred'} ) ) ) {
if ( Date_to_Days(Date::Calc::Today) < Date_to_Days( split( /-/, $borrower->{'debarred'} ) ) ) {
return 1;
}
}
return 0;
return Koha::Borrower::Debarments::IsDebarred($borrower->{borrowernumber});
}
1;