From 9b927e79230e24976acbf9a0a4354e2511ab98fb Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Mon, 22 Apr 2024 09:04:45 +0000
Subject: [PATCH] Bug 36431: Add screen message for NeedsTransfer when
 AutomaticItemReturn is off

Test plan:
Pick an item (without holds) with homebranch A and holdingbranch B.
(My SIP examples use RMA for A, NRD for B.)
Enable AutomaticItemReturn.
Check in this item at branch B via SIP.
* 09N20240422    10000020240422    160000APNRD|AONRD|ABperl01|
You should see something like:
* 101YNY20240422    105736AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|
Verify too that a transfer was started.
Now disable AutomaticItemReturn. Remove the transfer.
Check in this item at branch B via SIP.
You should see now something like:
101YNY20240422    105515AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|AFThis item must still be transferred to RMA branch.|
Verify that no transfer was started.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 C4/SIP/ILS/Transaction/Checkin.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm
index 56041c0b88..1ad0a4b736 100644
--- a/C4/SIP/ILS/Transaction/Checkin.pm
+++ b/C4/SIP/ILS/Transaction/Checkin.pm
@@ -133,6 +133,8 @@ sub do_checkin {
     if ( $messages->{NeedsTransfer} ) {
         $self->{item}->destination_loc( $messages->{NeedsTransfer} );
         $self->alert_type('04');    # send to other branch
+        $self->screen_msg( "This item must still be transferred to " . $messages->{NeedsTransfer} . " branch." )
+            if !C4::Context->preference('AutomaticItemReturn');
     }
     if ( $messages->{WasTransfered} ) {    # set into transit so tell unit
         $self->{item}->destination_loc( $item->homebranch );