Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 14671: Allow correct translation of CAS authentication

Browse source 
In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text.
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7

It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication.

This patch removes the use of acronym and abbr is authentication pages.

Test plan (example with fr-FR locale) :
- Without patch
- Update translation files : cd misc/translator ; perl translate update fr-FR
- You see in fr-FR-opac-bootstrap.po : msgid "If you have a "
- Is is translated in : msgstr "Si vous avez un compte "
- Apply patch
- Update translation files : cd misc/translator ; perl translate update fr-FR
- You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please "
- You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez "
- Same test for intranet authentication page
- Install the translation : cd misc/translator ; perl translate install fr-FR
- Look at the result

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Tranlated OK, tested in spanish es-ES

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Fridolin Somers 2015-08-11 10:19:05 +02:00 committed by Tomas Cohen Arazi
parent d8c0b836d6
commit 9bdd33de21
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
View file

@ -76,7 +76,7 @@
<p>Sorry, the CAS login failed.</p>
[% END %]
<p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account,
<p>If you have a CAS account,
[% IF ( casServerUrl ) %]
please <a href="[% casServerUrl %]">click here to login</a>.<p>
[% END %]

6
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
View file

@ -69,7 +69,7 @@
<!-- This is what is displayed if cas login has failed -->
<p>Sorry, the CAS login also failed, if you have a local login you may use that below.</p>
[% ELSE %]
If you have a <abbr title="Central Authentication Service">CAS</abbr> account, you may use that below.
If you have a CAS account, you may use that below.
[% END %]
[% ELSE %]
If you have a local account, you may use that below.
@ -84,7 +84,7 @@
[% END %]
[% IF ( casAuthentication ) %]
<h4>CAS login</h4>
<p>If you do not have a Shibboleth account, but you do have a <abbr title="Central Authentication Service">CAS</abbr> account,
<p>If you do not have a Shibboleth account, but you do have a CAS account,
[% ELSE %]
<h4>Local login</h4>
<p>If you do not have a Shibboleth account, but you do have a local login, then you may login below:</p>
@ -114,7 +114,7 @@
<p>Sorry, the CAS login failed.</p>
[% END %]
<p>If you have a <abbr title="Central Authentication Service">CAS</abbr> account,
<p>If you have a CAS account,
[% IF ( casServerUrl ) %]
please <a href="[% casServerUrl %]">click here to login</a>.<p>
[% END %]