Bug 18442: Add a test

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2017-04-21 18:44:05 -03:00 committed by Kyle M Hall
parent 416029ff2f
commit 9bf8142ee7
2 changed files with 16 additions and 1 deletions

View file

@ -1021,6 +1021,7 @@ sub checkauth {
# $return: 1 = valid user, 2 = superlibrarian
if ($return) {
# If DB user is logged in
$userid ||= $q_userid if $return == 2;
#_session_log(sprintf "%20s from %16s logged in at %30s.\n", $userid,$ENV{'REMOTE_ADDR'},(strftime '%c', localtime));

View file

@ -33,7 +33,7 @@ $schema->storage->txn_begin;
subtest 'checkauth() tests' => sub {
plan tests => 1;
plan tests => 2;
my $patron = $builder->build({ source => 'Borrower', value => { flags => undef } })->{userid};
@ -47,6 +47,20 @@ subtest 'checkauth() tests' => sub {
is( $userid, undef, 'checkauth() returns undef for userid if no logged in user (Bug 18275)' );
my $db_user_id = C4::Context->config('user');
my $db_user_pass = C4::Context->config('pass');
$cgi = Test::MockObject->new();
$cgi->mock( 'cookie', sub { return; } );
$cgi->mock( 'param', sub {
my ( $self, $param ) = @_;
if ( $param eq 'userid' ) { return $db_user_id; }
elsif ( $param eq 'password' ) { return $db_user_pass; }
else { return; }
});
( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
is ( $userid, $db_user_id, 'If DB user is logging in, it should be considered as logged in, i.e. checkauth return the relevant userid' );
C4::Context->_new_userenv; # For next tests
};
my $hash1 = hash_password('password');