Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 14321: QA Fix

Browse source 
Remove QA errors (keys on reference is experimental).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jonathan Druart 2015-09-16 11:12:04 +01:00 committed by Tomas Cohen Arazi
parent f8a58d310e
commit 9e8d89dd70
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Koha/Upload.pm
View file

@ -122,7 +122,7 @@ sub cgi {
sub count {
my ( $self ) = @_;
return scalar grep { !exists $self->{files}->{$_}->{errcode} } keys $self->{files};
return scalar grep { !exists $self->{files}->{$_}->{errcode} } keys %{ $self->{files} };
}
=head2 result
@ -135,7 +135,7 @@ sub result {
my ( $self ) = @_;
my @a = map { $self->{files}->{$_}->{id} }
grep { !exists $self->{files}->{$_}->{errcode} }
keys $self->{files};
keys %{ $self->{files} };
return @a? ( join ',', @a ): undef;
}
@ -149,7 +149,7 @@ sub result {
sub err {
my ( $self ) = @_;
my $err;
foreach my $f ( keys $self->{files} ) {
foreach my $f ( keys %{ $self->{files} } ) {
my $e = $self->{files}->{$f}->{errcode};
$err->{ $f } = $e if $e;
}
@ -328,7 +328,7 @@ sub _hook {
sub _done {
my ( $self ) = @_;
$self->{done} = 1;
foreach my $f ( keys $self->{files} ) {
foreach my $f ( keys %{ $self->{files} } ) {
my $fh = $self->_fh($f);
$self->_register( $f, $fh? tell( $fh ): undef )
if !$self->{files}->{$f}->{errcode};