Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27166: Set destination_loc to item->homebranch

Browse source 
In bug 21020 we used the issue to fetch the item and then the homebranch.
This fails when the item is not issued. We fetch the item already, so we
can use it directly

To test:
1 - Have an item belonging to branch A
2 - Check it in via sip at branch B:
    perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item CHESS1 -l FPL -m checkin
3 - The read command is blank and there is a warn about uninitialized data
4 - Apply patch
5 - Restart sip server
6 - Check the item in at branch A using the sip cli emulator
7 - Check it in at branch B
8 - This time the checkin should succeed and the output msg should be included

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-12-08 14:18:35 +00:00 committed by Jonathan Druart
parent 3126ae3443
commit 9ec0744ccc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/SIP/ILS/Transaction/Checkin.pm
View file

@ -133,7 +133,7 @@ sub do_checkin {
$self->alert_type('04'); # send to other branch
}
if ($messages->{WasTransfered}) { # set into transit so tell unit
$self->{item}->destination_loc($issue->item->homebranch);
$self->{item}->destination_loc($item->homebranch);
$self->alert_type('04'); # send to other branch
}
if ($messages->{ResFound} || $checkin_blocked_by_holds ) {