Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6679: Fix 3 perlcritic violations in C4/Record.pm

Browse source 
Expression form of "eval" at line 358, column 5.  See page 161 of PBP.  (Severity: 5)
Expression form of "eval" at line 367, column 5.  See page 161 of PBP.  (Severity: 5)
Expression form of "eval" at line 510, column 3.  See page 161 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Fixed conflict

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Mason James 2012-06-27 02:41:20 +12:00 committed by Tomas Cohen Arazi
parent 8554ce273c
commit a04e8a8bfc
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
C4/Record.pm
View file

@ -379,7 +379,7 @@ sub marc2csv {
} }
# Preprocessing # Preprocessing
eval $preprocess if ($preprocess); eval {$preprocess} if ($preprocess);
my $firstpass = 1; my $firstpass = 1;
if ( @$itemnumbers ) { if ( @$itemnumbers ) {
@ -396,7 +396,7 @@ sub marc2csv {
} }
# Postprocessing # Postprocessing
eval $postprocess if ($postprocess); eval {$postprocess} if ($postprocess);
return $output; return $output;
} }
@ -575,7 +575,7 @@ sub marcrecord2csv {
# Field processing # Field processing
my $marcfield = $tag->{fieldtag}; # This line fixes a retrocompatibility concern my $marcfield = $tag->{fieldtag}; # This line fixes a retrocompatibility concern
# The "processing" could be based on the $marcfield variable. # The "processing" could be based on the $marcfield variable.
eval $fieldprocessing if ($fieldprocessing); eval {$fieldprocessing} if ($fieldprocessing);
push @loop_values, $value; push @loop_values, $value;
} }