Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31664: Display pending transfer information on details page

Browse source 
If a transfer is requested, but not sent, we should display this information on biblio details for staff

This patch also removes nocancel parameter that was not used, passes transfer object directly to template

To test
1 - Manually transfer an item
2 - Note the item shows in transit on details page
3 - Remove the datesent to emulate a pending transfer
    UPDATE branchtransfers SET datesent = NULL itemnumber=1;
4 - View details page - no info on transfer
5 - Apply patch
6 - Item shows 'Transit pending'

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2022-09-30 12:01:36 +00:00 committed by Tomas Cohen Arazi
parent 83a79f0297
commit a1edf06869
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
catalogue/detail.pl
View file

@ -402,11 +402,8 @@ foreach my $item (@items) {
# Check the transit status
my $transfer = $item->get_transfer;
if ( $transfer && $transfer->in_transit ) {
$item_info->{transfertwhen} = $transfer->datesent;
$item_info->{transfertfrom} = $transfer->frombranch;
$item_info->{transfertto} = $transfer->tobranch;
$item_info->{nocancel} = 1;
if ( $transfer ) {
$item_info->{transfer} = $transfer;
}
foreach my $f (qw( itemnotes )) {

11
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
View file

@ -475,8 +475,13 @@ Note that permanent location is a code, and location may be an authval.
[% END %]
: due [% item.checkout.date_due | $KohaDates as_due_date => 1 %]
</span>
[% ELSIF ( item.transfertwhen ) %]
<span class="intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span>
[% ELSIF ( item.transfer ) %]
[% IF (item.transfer.datesent) %]
<span class="intransit">In transit from [% Branches.GetName( item.transfer.frombranch ) | html %] to [% Branches.GetName( item.transfer.tobranch ) | html %] since [% item.transfer.datesent | $KohaDates %]</span>
[% ELSE %]
<span class="transitrequested">Transit pending from [% Branches.GetName( item.transfer.frombranch ) | html %] to [% Branches.GetName( item.transfer.tobranch ) | html %] since [% item.transfer.daterequested | $KohaDates %]</span>
[% END %]
[% END %]
[% IF ( item.itemlost ) %]
@ -547,7 +552,7 @@ Note that permanent location is a code, and location may be an authval.
[% END %]
[% END %]
[% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || hold || ( Koha.Preference('UseRecalls') && recall ) ) %]
[% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfer || hold || ( Koha.Preference('UseRecalls') && recall ) ) %]
<span>Available</span>
[% END %]