Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog

Browse source 
When deleting a subscription which has not expired or which has linked
issues or items, a dialog asks for confirmation. This patch updates the
dialog to use Font Awesome icons.

Other minor change: Corrected capitalization in dialog heading.

To test, apply the patch and go to Serials.

- Locate a subscription which can be deleted and which has not expired,
  has linked items, or has linked issues.
- View the detail page for that subscription.
- Choose "Delete subscription" from the "Edit" menu.
- Verify that the confirmation dialog is correctly styled.
- Verify that the "No, don't delete" button works correctly.
- Verify that the "Yes, delete" button deletes the subscription.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2016-03-04 11:17:50 -05:00 committed by Brendan A Gallagher
parent b648e8c8bf
commit a234d27cbe
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
View file

@ -50,7 +50,7 @@ $(document).ready(function() {
[% END %]
[% IF ( NEEDSCONFIRMATION ) %]
<div id="circ_needsconfirmation" class="dialog alert">
<h3>Please Confirm Subscription deletion</h3>
<h3>Please confirm subscription deletion</h3>
<ul>
[% IF ( NOTEXPIRED ) %] <li>The subscription has not expired yet</li> [% END %]
@ -61,11 +61,11 @@ $(document).ready(function() {
<input type="hidden" name="subscriptionid" value="[% subscriptionid %]" />
<input type="hidden" name="issueconfirmed" value="1" />
<input type="hidden" name="op" value="del" />
<input type="submit" class="approve" value="Yes, delete (Y)" accesskey="y" />
<button type="submit" class="approve" accesskey="y"><i class="fa fa-fw fa-check"></i> Yes, delete (Y)</button>
</form>
<form method="get" action="/cgi-bin/koha/serials/subscription-detail.pl">
<input type="hidden" name="subscriptionid" value="[% subscriptionid %]" />
<input type="submit" class="deny" value="No, don't delete (N)" accesskey="n" />
<button type="submit" class="deny" accesskey="n"><i class="fa fa-fw fa-remove"></i> No, don't delete (N)</button>
</form>
</div>