Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28786: (QA follow-up) Fix qa warnings

Browse source 
FAIL   members/two_factor_auth.pl
   FAIL   file permissions
                File must have the exec flag
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt
   FAIL   filters
                missing_filter at line 42 (                        <p>Account: [% issuer %]</p>)
                missing_filter at line 43 (                        <p>Key: [% key_id %]</p>)
                missing_filter at line 54 (                            <input type="hidden" name="secret32" value="[% secret32 %]" />)
                missing_filter at line 58 (                                    <img id="qr_code" src="[% qr_code_url %]" />)
 FAIL   Koha/Auth/TwoFactorAuth.pm
   FAIL   pod coverage
                POD is missing for 'new'

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Marcel de Rooy 2022-01-13 07:52:33 +00:00 committed by Fridolin Somers
parent f03e2689d6
commit a47833c24b
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Koha/Auth/TwoFactorAuth.pm
View file

@ -36,6 +36,12 @@ my $ok = $auth->verify($pin_code, 1, $secret32);
It's based on Auth::GoogleAuth
=head2 METHODS
=head3 new
$obj = Koha::Auth::TwoFactorAuth->new({ patron => $p, secret => $s });
=cut
sub new {

8
koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt
View file

@ -39,8 +39,8 @@
<p>We recommend cloud-based mobile authenticator apps such as Authy, Duo Mobile, and LastPass. They can restore access if you lose your hardware device.</p>
<p>Can't scan the code?</p>
<p>To add the entry manually, provide the following details to the application on your phone.</p>
<p>Account: [% issuer %]</p>
<p>Key: [% key_id %]</p>
<p>Account: [% issuer | html %]</p>
<p>Key: [% key_id | html %]</p>
<p>Time based: Yes</p>
</div>
@ -51,11 +51,11 @@
<fieldset class="rows">
<input type="hidden" name="csrf_token" value="[% csrf_token | html %]" />
<input type="hidden" name="op" value="register-2FA" />
<input type="hidden" name="secret32" value="[% secret32 %]" />
<input type="hidden" name="secret32" value="[% secret32 | html %]" />
<ol>
<li>
<label for="qr_code">QR code: </label>
<img id="qr_code" src="[% qr_code_url %]" />
<img id="qr_code" src="[% qr_code_url | $raw %]" />
</li>
<li>
<label for="pin_code">Pin code: </label>

0
members/two_factor_auth.pl Normal file → Executable file
View file