Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 22953: Markup warning in OPAC user summary template

Browse source 
This patch makes a minor markup change to the OPAC user summary template
(opac-user.tt) in order to quiet warnings from the HTML validator. The
obsolete name attribute on two links is removed in favor of class names.
The JavaScript has been modified accordingly.

To reproduce the problem you should have the AllowCheckoutNotes system
preference enabled. Log in to the OPAC as a user who has checkouts and
view the "your summary" page. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."

This patch specifically addresses this warning:

 - "The name attribute is obsolete. Consider putting an id attribute on
   the nearest container instead."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the process of adding or editing an note on a checkout. It should
work correctly.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2019-05-21 16:29:06 +00:00 committed by Martin Renvoize
parent 4f81a252dd
commit a4844b85ee
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
View file

@ -346,8 +346,8 @@
[% IF ( Koha.Preference('AllowCheckoutNotes') ) %]
<td class="note">
<input type="text" name="note" data-issue_id="[% ISSUE.issue_id | html %]" data-origvalue="[% ISSUE.note | html %]" value="[% ISSUE.note | html %]" readonly>
<a class="btn" name="js_submitnote" id="save_[% ISSUE.issue_id | html %]" style="display:none;">Submit note</a>
<a class="btn" name="nonjs_submitnote" href="/cgi-bin/koha/opac-issue-note.pl?issue_id=[% ISSUE.issue_id | url %]">Edit / Create note</a>
<a class="btn js_submitnote" id="save_[% ISSUE.issue_id | html %]" style="display:none;">Submit note</a>
<a class="btn nonjs_submitnote" href="/cgi-bin/koha/opac-issue-note.pl?issue_id=[% ISSUE.issue_id | url %]">Edit / Create note</a>
</td>
[% END %]
</tr>
@ -812,7 +812,7 @@
[% IF ( Koha.Preference('AllowCheckoutNotes') ) %]
/* If JS enabled, show button, otherwise show link to redirect to a page where note can be submitted */
$("a[name='nonjs_submitnote']").hide();
$(".nonjs_submitnote").hide();
$("input[name='note']").prop('readonly', false);
$("input[name='note']").keypress(function(e){
@ -837,7 +837,7 @@
}
});
$("a[name='js_submitnote']").click(function(e){
$(".js_submitnote").click(function(e){
var $self = $(this);
var title = $(this).parent().siblings('.title').html();
var $noteinput = $(this).siblings('input[name="note"]').first();