Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21241: (follow-up) Code Golf

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2018-11-07 11:35:36 +00:00 committed by Nick Clemens
parent 3f7b2fa418
commit a4b38a18b3
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
C4/Suggestions.pm
View file

@ -503,17 +503,12 @@ sub ModSuggestion {
# fetch the entire updated suggestion so that we can populate the letter
my $full_suggestion = GetSuggestion( $suggestion->{suggestionid} );
my $patron = Koha::Patrons->find( $full_suggestion->{suggestedby} );
my $transport;
#If FallbackToSMSIfNoEmail syspref is enabled and the patron has a smsalertnumber but no email address then set message_transport_type of suggestion notice to sms
my $transport = 'email';
if (C4::Context->preference("FallbackToSMSIfNoEmail")) {
if (($patron->smsalertnumber) && (!$patron->email)) {
$transport="sms";
} else {
$transport="email";
}
} else {
$transport = "email";
$transport = ($patron->smsalertnumber) && (!$patron->email) ? 'sms' : 'email';
}
if (
my $letter = C4::Letters::GetPreparedLetter(
module => 'suggestions',