Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32349: Remove TEST_QA

Browse source 
There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.

Signed-off-by: Mason James <mtj@kohaaloha.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0adc264edb)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
(cherry picked from commit a375a94225)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2022-11-25 09:07:34 +01:00 committed by Lucas Gass
parent 74a6c576e7
commit a5e6294167
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
t/00-testcritic.t
View file

@ -1,18 +1,11 @@
#!/usr/bin/env perl
# This script can be used to run perlcritic on perl files in koha
# The script is purely optional requiring Test::Perl::Critic to be installed
# and the environment variable TEST_QA to be set
use Modern::Perl;
use Test::More;
use English qw(-no_match_vars);
if ( not $ENV{TEST_QA} ) {
my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run';
plan( skip_all => $msg );
}
eval { require Test::Perl::Critic; };
if ( $EVAL_ERROR ) {