Browse Source

Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions

Clicking on "Delete record" while there are existent subscriptions no
longer delete the record and the subscription. Instead an alert box
inform the user that he must delete all subscription before deleting the
record.

To test:
1) Add a subscription to a biblio, or check a biblio which has one
   attached already.
2) Remove all items if there are any.
3) Apply patch.
4) Confirm that the 'Delete record' item is disabled in the list.
5) Attempt to 'Delete record', you should recieve
   an error message stating to delete all subscriptions before
   deleting record.
6) Sign off.

Sponsored by: Lunds Universitetsbibliotek

Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>

Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
22.05.x
Marion Durand 3 years ago
committed by Fridolin Somers
parent
commit
a7771f0503
  1. 1
      koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc
  2. 2
      koha-tmpl/intranet-tmpl/prog/js/catalog.js

1
koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc

@ -10,6 +10,7 @@
[% SET cancelled = Context.Scalar(orders, "filter_by_cancelled") %]
var countorders = [% current.count || 0 | html %];
var countdeletedorders = [% cancelled.count || 0 | html %];
var subscriptionscount = [% biblio.subscriptions.count || 0 | html %];
var searchid = '[% searchid | html %]';
/* provide Z3950 search points */

2
koha-tmpl/intranet-tmpl/prog/js/catalog.js

@ -44,6 +44,8 @@ function confirm_deletion(link) {
}
} else if ( holdcount > 0 ) {
is_confirmed = confirm( __("%s holds(s) for this record. Are you sure you want to delete this record?").format(holdcount));
} else if (subscriptionscount > 0){
is_confirmed = alert(__("%s subscription(s) are attached to this record. You must delete all subscription before deleting this record.").format(subscriptionscount));
} else {
is_confirmed = confirm( __("Are you sure you want to delete this record?") );
}

Loading…
Cancel
Save