Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11218: fix Item Due notices not being generated

Browse source 
To test:
- Check out at least 3 items, due dates should be today, sometime in
  the past and one day after tomorrow.
- Edit the message options - activate DUE and PREDUE notices with
  days in advance = 2
- Run the advance_notices.pl script with -v -c
  Result: Only a PREDUE notice is generated
- Run the advance_notices.pl script with -v -c -m 2
  Result: Only the PREDUE message is generated correctly.
- Run t/db_dependent/Circulation.t
  - without first patch: all tests pass.
  - with first patch: some tests will fail.
- Apply patch.
- Rerun script, now PREDUE and DUE notices should be
  generated.
- Run t/db_dependent/Circulation.t again, all tests should pass.

Add more items with different due dates, rerun and check results.

Run t/Circulation.t to confirm all tests pass.
- Apply the patch

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Passes functional tests and automated tests.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Katrin Fischer 2013-11-08 00:31:09 +01:00 committed by Galen Charlton
parent 2b391db890
commit a8bc7c9ef8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/Circulation.pm
View file

@ -2433,7 +2433,7 @@ FROM issues
LEFT JOIN items USING (itemnumber) LEFT JOIN items USING (itemnumber)
LEFT OUTER JOIN branches USING (branchcode) LEFT OUTER JOIN branches USING (branchcode)
WHERE returndate is NULL WHERE returndate is NULL
HAVING days_until_due > 0 AND days_until_due < ? HAVING days_until_due >= 0 AND days_until_due <= ?
END_SQL END_SQL
my @bind_parameters = ( $params->{'days_in_advance'} ); my @bind_parameters = ( $params->{'days_in_advance'} );