Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold

Browse source 
This patch actually fixes the issue described on bug 23116.

Test plan:
See bug 23116 and comment 5. Important to note that the later comparison with
itemAlreadyOnHold assumes that the variable is a string.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-12-04 16:04:45 +01:00 committed by Martin Renvoize
parent ece3e5a6a2
commit ad3e5bae0c
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
reserve/request.pl
View file

@ -548,8 +548,8 @@ foreach my $biblionumber (@biblionumbers) {
$item->{'holdallowed'} = $branchitemrule->{'holdallowed'};
my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $pickup );
$item->{not_holdable} = $can_item_be_reserved->{status} unless ( $can_item_be_reserved->{status} eq 'OK' );
my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $pickup )->{status};
$item->{not_holdable} = $can_item_be_reserved unless $can_item_be_reserved eq 'OK';
$item->{item_level_holds} = Koha::IssuingRules->get_opacitemholds_policy( { item => $item_object, patron => $patron } );
@ -557,7 +557,7 @@ foreach my $biblionumber (@biblionumbers) {
!$item->{cantreserve}
&& !$exceeded_maxreserves
&& IsAvailableForItemLevelRequest($item_object, $patron)
&& $can_item_be_reserved->{status} eq 'OK'
&& $can_item_be_reserved eq 'OK'
)
{
$item->{available} = 1;