Browse Source

Bug 11182: (QA followup) fix warning if itemBarcodeFallbackSearch set

To reproduce:
- On top of the previous patches, if you enable the
  itemBarcodeFallbackSearch syspref and do a search for a term that
  returns at least one result, there will be warnings for each result
  without items attached.

To test:

- In the checkout form enter a term that should return results (some of
  them without items attached)
=> There are warnings on the logs regarding a split of undef variable
- Apply the patch
- Repeat the first step
=> No warnings

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3.16.x
Tomás Cohen Arazi 10 years ago
committed by Galen Charlton
parent
commit
ad8d567f18
  1. 10
      circ/circulation.pl

10
circ/circulation.pl

@ -315,10 +315,12 @@ if ($barcode) {
C4::Search::new_record_from_zebra('biblioserver',$hit) );
# offer all barcodes individually
foreach my $barcode ( sort split(/\s*\|\s*/, $chosen->{barcode}) ) {
my %chosen_single = %{$chosen};
$chosen_single{barcode} = $barcode;
push( @options, \%chosen_single );
if ( $chosen->{barcode} ) {
foreach my $barcode ( sort split(/\s*\|\s*/, $chosen->{barcode}) ) {
my %chosen_single = %{$chosen};
$chosen_single{barcode} = $barcode;
push( @options, \%chosen_single );
}
}
}
$template->param( options => \@options );

Loading…
Cancel
Save