Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33684: Make mandatory date fields required when editing a patron

Browse source 
Date fields in BorrowerMandatoryField are not required by the validation
form when a new patron is added or modified.

This is because the 'required' prop does not exist on the input element
when the flatpickr instance is created.
We should either add it in the DOM directly (tt), but it will require to
do it "manually" for each date fields, or add it when we add it to the
inputs. This patch implements the second option.

Test plan:
1. Add "dateofbirth" to syspref BorrowerMandatoryField.
2. Add patron and leave date of birth input field empty.
3. Save.
=> Form is not submitted and you are asked to fill in a date of birth

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

https://bugs.koha-community.org/show_bug.cgi?id=33648
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jonathan Druart 2023-05-09 10:11:19 +02:00 committed by Tomas Cohen Arazi
parent 49803c311b
commit ae3d6f1876
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/js/members.js
View file

@ -190,7 +190,11 @@ $(document).ready(function(){
});
var mandatory_fields = $("input[name='BorrowerMandatoryField']").val().split ('|');
$(mandatory_fields).each(function(){
$("[name='"+this+"']").attr('required', 'required');
let input = $("[name='"+this+"']")
if ( input.hasClass('flatpickr') ) {
$(input).siblings('.flatpickr_wrapper').find('input.flatpickr').prop('required', true)
}
input.prop('required', true);
});
$("fieldset.rows input, fieldset.rows select").addClass("noEnterSubmit");