Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21819: (QA follow-up) Replace onchange() in touched code

Browse source 
AFAIK we should not call document...onchange() and assume that it works.
Apparently, it does at least in some browsers. But we are not sure.
We could easily replace them here by the documented jQuery counterpart.

Note: If you try git grep -l -E "onchange\(" you will find some
occurrences in two libraries and only in one js file (this one).
We should replace all occurrences here; will open a new report for that.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Verified that the change event was triggered: span should expand/collapse.

Signed-off-by: Andreas Roussos <arouss1980@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2018-11-20 16:32:46 +01:00 committed by Nick Clemens
parent a9fc00db03
commit aeaf74b7cc
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js
View file

@ -256,11 +256,9 @@ function editAction( mmta_id, ordering, action, field_number, from_field, from_s
document.getElementById('to_field').value = to_field;
document.getElementById('to_subfield').value = to_subfield;
if ( to_regex_search == '' && to_regex_replace == '' && to_regex_modifiers == '' ) {
document.getElementById('to_field_regex').checked = false;
document.getElementById('to_field_regex').onchange();
$('#to_field_regex').prop('checked', false).change();
} else {
document.getElementById('to_field_regex').checked = true;
document.getElementById('to_field_regex').onchange();
$('#to_field_regex').prop('checked', true).change();
$("#to_regex_search").val(to_regex_search);
$("#to_regex_replace").val(to_regex_replace);
$("#to_regex_modifiers").val(to_regex_modifiers);