Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12976: Fix some comment in tests

Browse source 
Previous comments were wrong.
Actually the main part of price values is correct.
Only some rounding and tax values are badly calculated.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2014-11-17 12:45:22 +01:00 committed by Tomas Cohen Arazi
parent d374d87b41
commit aed056a636
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/Acquisition.pm
View file

@ -2871,8 +2871,6 @@ sub populate_order_with_prices {
}
if ($receiving) {
# The following is completely wrong. Will be fixed later.
# See the unit tests to know what is wrong.
if ( $bookseller->{listincgst} ) {
$order->{unitpricegsti} = Koha::Number::Price->new( $order->{unitprice} )->round;
$order->{unitpricegste} = Koha::Number::Price->new(

8
t/Prices.t
View file

@ -120,9 +120,8 @@ for my $currency_format ( qw( US FR ) ) {
receiving => 1,
}
);
# Note that this configuration is *not* correct!
# unitpricegsti should be 75.28
# totalgst should be 150.56
# Note that this configuration is correct \o/
compare(
{
got => $order_0_0->{unitpricegsti},
@ -343,6 +342,7 @@ for my $currency_format ( qw( US FR ) ) {
# Note that this configuration is *not* correct!
# rrp gsti should be 82 (what we inserted!)
# => Actually we need to fix the inserted value (here we have 82.01 in DB)
# gstvalue should be 7.03 instead of 7.02
compare(
@ -410,8 +410,6 @@ for my $currency_format ( qw( US FR ) ) {
}
);
# Note that this configuration is *not* correct!
# unitpricegsti should be 71.69
# totalgsti should be 143.38
# gstvalue should be 7.03
compare(
{