Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27926: (QA follow-up) Switch to using data-order

Browse source 
This patch switches away from using the title attribute for ordering and
instead uses data-order which is supported in modern DataTables.  This
has the effect of allowing our ordering to continue to work but without
adding the unwanted tooltip on hover.

Test plan
1/ Ensure sorting is still working as expected
2/ Hover over any of the date of birth fields and note that you are not
longer faced with a tooltip.
3/ Signoff

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2021-03-12 08:48:59 +00:00 committed by Jonathan Druart
parent a1f5f363bc
commit af0fc2f0f0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
View file

@ -4,7 +4,7 @@
<tr>
<th>Name</th>
<th>Card number</th>
<th class="title-string">Date of birth</th>
<th>Date of birth</th>
<th>Category</th>
<th>Library</th>
<th>Address</th>
@ -26,7 +26,7 @@
<td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td>
[% END %]
<td>[% borrower.cardnumber | html %]</td>
<td><span title="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</span></td>
<td data-order="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</td>
<td>[% Categories.GetName( borrower.categorycode ) | html %]</td>
<td>[% Branches.GetName( borrower.branchcode ) | html %]</td>
<td>[% borrower.address | html %]</td>