Browse Source

Bug 23843: Add mapping to Koha::Club::Holds

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
remotes/origin/19.11.x
Tomás Cohen Arazi 3 years ago
committed by Martin Renvoize
parent
commit
af2cd5e303
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
  1. 25
      Koha/Club/Hold.pm
  2. 7
      Koha/REST/V1/Clubs/Holds.pm

25
Koha/Club/Hold.pm

@ -40,7 +40,7 @@ Represents a hold made for every member of club
=head1 API
=head2 Class Methods
=head2 Class methods
=cut
@ -125,7 +125,26 @@ sub add {
}
=head3 type
=head3 to_api_mapping
This method returns the mapping for representing a Koha::Club::Hold object
on the API.
=cut
sub to_api_mapping {
return {
id => 'club_hold_id',
club_id => 'club_id',
biblio_id => 'biblio_id',
item_id => 'item_id'
};
}
=head2 Internal methods
=head3 _type
=cut
@ -139,4 +158,4 @@ Agustin Moyano <agustinmoyano@theke.io>
=cut
1;
1;

7
Koha/REST/V1/Clubs/Holds.pm

@ -119,9 +119,10 @@ sub add {
item_type => $item_type
});
my $mapping = _to_api($club_hold->unblessed);
return $c->render( status => 201, openapi => $mapping );
return $c->render(
status => 201,
openapi => $club_hold->to_api
);
}
catch {
if ( blessed $_ and $_->isa('Koha::Exceptions::Object') ) {

Loading…
Cancel
Save