From afb9cd8e1ccf941ae8cf6e1070dd41a285dcb86b Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Fri, 10 May 2024 09:30:53 -0300
Subject: [PATCH] Bug 34041: (follow-up) escape double dashes to prevent issues

Having double dashes inside a commmented block is not valid XML. This
patch restores it, with an added message explaining it

To test:
1. Run:
   $ xmllint etc/z3950/config.xml
=> FAIL: You get:
etc/z3950/config.xml:5: parser error : Double hyphen within comment: <!--
  <config>
      <z3950_responder_options>
      <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options
2. Apply this patch
3. Repeat 1
=> SUCCESS: All good!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 11c69496bcd216ad264acd87409e5160c73995bf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 etc/z3950/config.xml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/etc/z3950/config.xml b/etc/z3950/config.xml
index 8f948f8665..f909bac718 100644
--- a/etc/z3950/config.xml
+++ b/etc/z3950/config.xml
@@ -1,8 +1,10 @@
 <yazgfs>
- <!-- See z3950_responder.pl for available options. The options -c, -u and -p are already passed automatically by koha-z3950-responder -->
+ <!-- See z3950_responder.pl for available options. The options -c, -u and -p are
+      already passed automatically by koha-z3950-responder, note that dashes for the
+      add-item-status switch are escaped for XML compliance but should not if uncommented -->
  <!--
   <config>
-      <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options>
+      <z3950_responder_options>\-\-add-item-status k -t 5</z3950_responder_options>
   </config>
  -->