Browse Source

Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly

CGI->url_param does not always return the parameters in the same order.

Test plan:
0/ Recreate the random failure, does not apply the patch and run
t/Auth_with_shibboleth.t several times.
You will notice that it fails inconsistenly
1/ Apply the patch and confirm that it now passes 100% of the time

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
20.05.x
Jonathan Druart 2 years ago
committed by Martin Renvoize
parent
commit
b022b37db7
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
  1. 2
      C4/Auth_with_shibboleth.pm

2
C4/Auth_with_shibboleth.pm

@ -199,7 +199,7 @@ sub _get_return {
my $uri_base_part = _get_uri() . get_script_name();
my $uri_params_part = '';
foreach my $param ( $query->url_param() ) {
foreach my $param ( sort $query->url_param() ) {
# url_param() always returns parameters that were deleted by delete()
# This additional check ensure that parameter was not deleted.
my $uriPiece = $query->param($param);

Loading…
Cancel
Save