Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10038: fix doubled 'default' entry when creating a new authority type

Browse source 
Test plan:
- Create a new authority type
- Click MARC structure
- Verify the pull down has only 1 entry for Default
- Go on the authority type home (admin/authtypes.pl)
- Click on the "MARC structure" link for the default type
- Verify the pull down has only 1 entry for Default

This patch adds a sort (on the authtypecode) for these 2 lists.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Works as described. No koha-qa errors.

When creating a new framework it would be better to have Default
on top, but one is way better than two :)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Agreed, one is better than two :)
All tests and QA script pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Jonathan Druart 2013-07-17 15:02:43 +02:00 committed by Galen Charlton
parent 66de7d0e17
commit b04118df82
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
admin/auth_tag_structure.pl
View file

@ -57,7 +57,7 @@ my ($template, $loggedinuser, $cookie)
# get authtype list
my $authtypes = getauthtypes;
my @authtypesloop = ();
foreach my $thisauthtype ( keys %{$authtypes} ) {
foreach my $thisauthtype ( sort keys %{$authtypes} ) {
push @authtypesloop,
{ value => $thisauthtype,
selected => $thisauthtype eq $authtypecode,
@ -209,6 +209,7 @@ if ($op eq 'add_form') {
push @existingauthtypeloop,\%line;
}
}
@existingauthtypeloop = sort { lc($a->{authtypetext}) cmp lc($b->{authtypetext}) }@existingauthtypeloop;
$template->param(existingauthtypeloop => \@existingauthtypeloop,
authtypecode => $authtypecode,
);

6
koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
View file

@ -190,10 +190,13 @@ return false;
<input type="hidden" name="authtypecode" value="[% authtypecode %]" />
Create authority framework for [% authtypecode %] using
<select name="existingauthtypecode">
<option value="">Default</option>
[% FOREACH existingauthtypeloo IN existingauthtypeloop %]
[% IF existingauthtypeloo.value == "" %]
<option value="" selected="selected">[% existingauthtypeloo.authtypetext %]</option>
[% ELSE %]
<option value="[% existingauthtypeloo.value %]">[% existingauthtypeloo.authtypetext %]</option>
[% END %]
[% END %]
</select>
<input type="submit" value="OK" class="submit" />
</form>
@ -209,7 +212,6 @@ return false;
<h2>Select an authority framework</h2>
<form action="[% script_name %]" method="post">
<select name="authtypecode">
<option value="">Default</option>
[% FOREACH authtypeloo IN authtypeloop %]
[% IF ( authtypeloo.selected ) %]
<option value="[% authtypeloo.value %]" selected="selected">[% authtypeloo.authtypetext %]</option>